Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update analysis options for nnbd #3319

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Dec 10, 2020

With NNBD assert(foo != null) for a non nullable foo generates an analysis error.
However as long as we support mixed-mode we want these asserts it, so disabling the check.

@amirh amirh requested a review from blasten December 10, 2020 20:51
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh amirh merged commit 2f708d7 into flutter:master Dec 10, 2020
@amirh amirh deleted the allow-null-checks branch December 10, 2020 23:59
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
With NNBD assert(foo != null) for a non nullable foo generates an analysis error.
However as long as we support mixed-mode we want these asserts it, so disabling the check.
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
With NNBD assert(foo != null) for a non nullable foo generates an analysis error.
However as long as we support mixed-mode we want these asserts it, so disabling the check.
samandmoore added a commit to Betterment/plugins that referenced this pull request Apr 21, 2021
…m-changes

* upstream-share-final-null-release: (233 commits)
  [q-w] Update Flutter SDK constraint (flutter#3323)
  [i-p] Update Flutter SDK constraint (flutter#3322)
  [d-g] Update Flutter SDK constraint (flutter#3321)
  [a-c] Update Flutter SDK constraint (flutter#3320)
  [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309)
  Exclude null-safe plugins from testing on stable (flutter#3318)
  [documentation] [url_launcher] fix for readme code sample (flutter#3308)
  [camera] Add zoom support to platform interface (flutter#3312)
  update analysis options for nnbd (flutter#3319)
  [camera] Suppress unchecked cast warning in java test (flutter#3316)
  [image_picker] [integration_test] Fixes to make the tree green (flutter#3317)
  [camera] Expanded platform interface to support setting flash mode (flutter#3313)
  [Espresso] Android Code Inspection and Clean up (flutter#3111)
  [camera] Add `camera_platform_interface` package (flutter#3253)
  [camera] Support Android 30 (flutter#3299)
  bump integration test to 1.0.0 (flutter#3295)
  [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288)
  Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279)
  [file_selector_platform_interface] Migrate to cross_file package (flutter#3286)
  Fix broken link (flutter#3280)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants