Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Add zoom support to platform interface #3312

Merged
merged 4 commits into from
Dec 11, 2020

Conversation

mvanbeusekom
Copy link
Contributor

Description

Adds the required methods necessary to implement zoom support to the camera_platform_interface. Once this PR has landed packages implementing the camera_platform_interface will be able to add zoom support to the camera implementations.

Related Issues

This PR is a start to implement zoom support as requested in issue: flutter/flutter#28694

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@mvanbeusekom mvanbeusekom changed the title Add zoom support to platform interface [camera] Add zoom support to platform interface Dec 9, 2020
@mvanbeusekom mvanbeusekom force-pushed the camera_zoom_platform_interface branch from a770961 to 3bdecf5 Compare December 10, 2020 13:52
@mvanbeusekom mvanbeusekom requested a review from ditman December 10, 2020 14:48
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nit

@mvanbeusekom mvanbeusekom force-pushed the camera_zoom_platform_interface branch from 3bdecf5 to 29d4b11 Compare December 10, 2020 20:33
@mvanbeusekom mvanbeusekom merged commit 7d39247 into flutter:master Dec 11, 2020
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
* Add zoom support to platform interface

* Added method to retrieve min supported zoom level

* Bumped version to 1.0.2

* Fixed small typo
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
* Add zoom support to platform interface

* Added method to retrieve min supported zoom level

* Bumped version to 1.0.2

* Fixed small typo
samandmoore added a commit to Betterment/plugins that referenced this pull request Apr 21, 2021
…m-changes

* upstream-share-final-null-release: (233 commits)
  [q-w] Update Flutter SDK constraint (flutter#3323)
  [i-p] Update Flutter SDK constraint (flutter#3322)
  [d-g] Update Flutter SDK constraint (flutter#3321)
  [a-c] Update Flutter SDK constraint (flutter#3320)
  [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309)
  Exclude null-safe plugins from testing on stable (flutter#3318)
  [documentation] [url_launcher] fix for readme code sample (flutter#3308)
  [camera] Add zoom support to platform interface (flutter#3312)
  update analysis options for nnbd (flutter#3319)
  [camera] Suppress unchecked cast warning in java test (flutter#3316)
  [image_picker] [integration_test] Fixes to make the tree green (flutter#3317)
  [camera] Expanded platform interface to support setting flash mode (flutter#3313)
  [Espresso] Android Code Inspection and Clean up (flutter#3111)
  [camera] Add `camera_platform_interface` package (flutter#3253)
  [camera] Support Android 30 (flutter#3299)
  bump integration test to 1.0.0 (flutter#3295)
  [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288)
  Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279)
  [file_selector_platform_interface] Migrate to cross_file package (flutter#3286)
  Fix broken link (flutter#3280)
  ...
@mvanbeusekom mvanbeusekom deleted the camera_zoom_platform_interface branch September 21, 2021 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants