Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file_selector_platform_interface] Add platform interface for new file_selector plugin #2995

Merged
merged 14 commits into from
Sep 25, 2020
Merged

[file_selector_platform_interface] Add platform interface for new file_selector plugin #2995

merged 14 commits into from
Sep 25, 2020

Conversation

jasonpanelli
Copy link
Contributor

@jasonpanelli jasonpanelli commented Sep 3, 2020 •
edited
Loading

Description

Add the platform interface for new file_selector plugin.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jasonpanelli jasonpanelli changed the title [file_selector] Add platform interface for new file_selector plugin [file_selector_platform_interface] Add platform interface for new file_selector plugin Sep 4, 2020
@jasonpanelli jasonpanelli marked this pull request as ready for review September 8, 2020 20:13
@jasonpanelli
Copy link
Contributor Author

@tugorez @ditman

ditman
ditman reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! A few minor nits!

@tugorez
Copy link
Contributor

tugorez commented Sep 9, 2020

@jasonpanelli PTAL https://github.com/flutter/plugins/pull/2995/checks?check_run_id=1088849366

@ditman
Copy link
Member

ditman commented Sep 24, 2020

I think this is good to merge! I'll try to add ourselves to the CODEOWNERS of the repo :)

@ditman ditman merged commit b611445 into flutter:master Sep 25, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@jasonpanelli @jorgefspereira
[file_selector_platform_interface] Add platform interface for new fil…
670aafe 
…e_selector plugin (flutter#2995)
@jpnurmi jpnurmi mentioned this pull request Nov 8, 2020
Closed
13 tasks
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@jasonpanelli
[file_selector_platform_interface] Add platform interface for new fil…
b398a02 
…e_selector plugin (flutter#2995)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g left review comments

@ditman ditman ditman left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasonpanelli @tugorez @ditman @stuartmorgan-g @googlebot