[google_sign_in_web] Fix pedantic lints (#2365)

Author: Michael Klimushyn

packages/google_sign_in/google_sign_in_web/CHANGELOG.md

@@ -1,7 +1,11 @@
+## 0.8.1+1
+
+* Add missing documentation.
+
 ## 0.8.1
 
 * Add podspec to enable compilation on iOS.
 
 ## 0.8.0
 
-* Flutter for web initial release
+* Flutter for web initial release

packages/google_sign_in/google_sign_in_web/analysis_options.yaml

@@ -19,11 +19,17 @@ import 'src/utils.dart' show gapiUserToPluginUserData;
 const String _kClientIdMetaSelector = 'meta[name=google-signin-client_id]';
 const String _kClientIdAttributeName = 'content';
 
+/// This is only exposed for testing. It shouldn't be accessed by users of the
+/// plugin as it could break at any point.
 @visibleForTesting
 String gapiUrl = 'https://apis.google.com/js/platform.js';
 
-/// Implementation of the google_sign_in plugin for Web
+/// Implementation of the google_sign_in plugin for Web.
 class GoogleSignInPlugin extends GoogleSignInPlatform {
+  /// Constructs the plugin immediately and begins initializing it in the
+  /// background.
+  ///
+  /// The plugin is completely initialized when [initialized] completed.
   GoogleSignInPlugin() {
     _autoDetectedClientId = html
         .querySelector(_kClientIdMetaSelector)
@@ -34,12 +40,15 @@ class GoogleSignInPlugin extends GoogleSignInPlatform {
 
   Future<void> _isGapiInitialized;
 
+  /// This is only exposed for testing. It shouldn't be accessed by users of the
+  /// plugin as it could break at any point.
   @visibleForTesting
   Future<void> get initialized => _isGapiInitialized;
 
   String _autoDetectedClientId;
   FutureOr<auth2.GoogleUser> _lastSeenUser;
 
+  /// Factory method that initializes the plugin with [GoogleSignInPlatform].
   static void registerWith(Registrar registrar) {
     GoogleSignInPlatform.instance = GoogleSignInPlugin();
   }

packages/google_sign_in/google_sign_in_web/lib/google_sign_in_web.dart

@@ -17,6 +17,8 @@ import 'utils.dart' show injectJSLibraries;
 external set gapiOnloadCallback(Function callback);
 
 // This name must match the external setter above
+/// This is only exposed for testing. It shouldn't be accessed by users of the
+/// plugin as it could break at any point.
 @visibleForTesting
 const String kGapiOnloadCallbackFunctionName = "gapiOnloadCallback";
 String _addOnloadToScript(String url) => url.startsWith('data:')

packages/google_sign_in/google_sign_in_web/lib/src/load_gapi.dart

@@ -29,6 +29,8 @@ Future<void> injectJSLibraries(List<String> libraries,
   return Future.wait(loading);
 }
 
+/// Utility method that converts `currentUser` to the equivalent
+/// [GoogleSignInUserData].
 GoogleSignInUserData gapiUserToPluginUserData(auth2.GoogleUser currentUser) {
   assert(currentUser != null);
   final auth2.BasicProfile profile = currentUser.getBasicProfile();

packages/google_sign_in/google_sign_in_web/lib/src/utils.dart

@@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system
   for signing in with a Google account on Android, iOS and Web.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_web
-version: 0.8.1
+version: 0.8.1+1
 
 flutter:
   plugin:

packages/google_sign_in/google_sign_in_web/pubspec.yaml

@@ -47,7 +47,7 @@ void main() {
   });
 
   group('Successful .init, then', () {
-    setUp(() async {
+    setUp(() {
       plugin.init(
         hostedDomain: 'foo',
         scopes: <String>['some', 'scope'],

packages/google_sign_in/google_sign_in_web/test/auth2_test.dart

@@ -17,7 +17,6 @@ CUSTOM_ANALYSIS_PLUGINS=(
   "in_app_purchase"
   "camera"
   "google_sign_in/google_sign_in"
-  "google_sign_in/google_sign_in_web"
 )
 # Comma-separated string of the list above
 readonly CUSTOM_FLAG=$(IFS=, ; echo "${CUSTOM_ANALYSIS_PLUGINS[*]}")