Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit d8812bc

Browse files
[ci] Complete architecture switch for iOS (#7066)
Enables the new architecture tests for iOS and turns down the old ones. Platform tests are now run on ARM, and the build-all test is run on Intel for coverage of building on both architectures.
1 parent 84ad624 commit d8812bc

File tree

1 file changed

+16
-127
lines changed

1 file changed

+16
-127
lines changed

.ci.yaml

Lines changed: 16 additions & 127 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ targets:
6464
target_file: macos_lint_podspecs.yaml
6565

6666
### macOS desktop tasks ###
67-
# macos-platform_tests builds all the plugins on ARM, so this build is run
67+
# macos_platform_tests builds all the plugins on ARM, so this build is run
6868
# on Intel to give us build coverage of both host types.
6969
- name: Mac_x64 build_all_plugins master
7070
recipe: plugins/plugins
@@ -104,29 +104,9 @@ targets:
104104
target_file: macos_platform_tests.yaml
105105

106106
### iOS tasks ###
107-
# TODO(stuartmorgan): Swap the architecture of this and ios_platform_tests_*
108-
# once simulator tests are reliable on the ARM infrastructure. See discussion
109-
# at https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
110-
- name: Mac_arm64 ios_build_all_plugins master
111-
recipe: plugins/plugins
112-
timeout: 30
113-
properties:
114-
channel: master
115-
add_recipes_cq: "true"
116-
version_file: flutter_master.version
117-
target_file: ios_build_all_plugins.yaml
118-
119-
- name: Mac_arm64 ios_build_all_plugins stable
120-
recipe: plugins/plugins
121-
timeout: 30
122-
properties:
123-
channel: stable
124-
add_recipes_cq: "true"
125-
version_file: flutter_stable.version
126-
target_file: ios_build_all_plugins.yaml
127-
107+
# ios_platform_tests builds all the plugins on ARM, so this build is run
108+
# on Intel to give us build coverage of both host types.
128109
- name: Mac_x64 ios_build_all_plugins master
129-
bringup: true # New task, replaces ARM version
130110
recipe: plugins/plugins
131111
timeout: 30
132112
properties:
@@ -136,7 +116,6 @@ targets:
136116
target_file: ios_build_all_plugins.yaml
137117

138118
- name: Mac_x64 ios_build_all_plugins stable
139-
bringup: true # New task, replaces ARM version
140119
recipe: plugins/plugins
141120
timeout: 30
142121
properties:
@@ -145,145 +124,59 @@ targets:
145124
version_file: flutter_stable.version
146125
target_file: ios_build_all_plugins.yaml
147126

148-
# TODO(stuartmorgan): Swap the architecture of this and ios_build_all_plugins
149-
# once simulator tests are reliable on the ARM infrastructure. See discussion
150-
# at https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
151-
- name: Mac_x64 ios_platform_tests_1_of_4 master
152-
recipe: plugins/plugins
153-
timeout: 60
154-
properties:
155-
add_recipes_cq: "true"
156-
version_file: flutter_master.version
157-
target_file: ios_platform_tests.yaml
158-
package_sharding: "--shardIndex 0 --shardCount 4"
159-
160-
- name: Mac_x64 ios_platform_tests_2_of_4 master
161-
recipe: plugins/plugins
162-
timeout: 60
163-
properties:
164-
add_recipes_cq: "true"
165-
version_file: flutter_master.version
166-
target_file: ios_platform_tests.yaml
167-
package_sharding: "--shardIndex 1 --shardCount 4"
168-
169-
- name: Mac_x64 ios_platform_tests_3_of_4 master
170-
recipe: plugins/plugins
171-
timeout: 60
172-
properties:
173-
add_recipes_cq: "true"
174-
version_file: flutter_master.version
175-
target_file: ios_platform_tests.yaml
176-
package_sharding: "--shardIndex 2 --shardCount 4"
177-
178-
- name: Mac_x64 ios_platform_tests_4_of_4 master
179-
recipe: plugins/plugins
180-
timeout: 60
181-
properties:
182-
add_recipes_cq: "true"
183-
version_file: flutter_master.version
184-
target_file: ios_platform_tests.yaml
185-
package_sharding: "--shardIndex 3 --shardCount 4"
186-
127+
# TODO(stuartmorgan): Change all of the ios_platform_tests_* task timeouts
128+
# to 60 minutes once https://github.com/flutter/flutter/issues/119750 is
129+
# fixed.
187130
- name: Mac_arm64 ios_platform_tests_shard_1 master - plugins
188-
bringup: true # New task; will replace Intel version
189131
recipe: plugins/plugins
190-
timeout: 60
132+
timeout: 120
191133
properties:
192134
add_recipes_cq: "true"
193135
version_file: flutter_master.version
194136
target_file: ios_platform_tests.yaml
195137
package_sharding: "--shardIndex 0 --shardCount 5"
196138

197139
- name: Mac_arm64 ios_platform_tests_shard_2 master - plugins
198-
bringup: true # New task; will replace Intel version
199140
recipe: plugins/plugins
200-
timeout: 60
141+
timeout: 120
201142
properties:
202143
add_recipes_cq: "true"
203144
version_file: flutter_master.version
204145
target_file: ios_platform_tests.yaml
205146
package_sharding: "--shardIndex 1 --shardCount 5"
206147

207148
- name: Mac_arm64 ios_platform_tests_shard_3 master - plugins
208-
bringup: true # New task; will replace Intel version
209149
recipe: plugins/plugins
210-
timeout: 60
150+
timeout: 120
211151
properties:
212152
add_recipes_cq: "true"
213153
version_file: flutter_master.version
214154
target_file: ios_platform_tests.yaml
215155
package_sharding: "--shardIndex 2 --shardCount 5"
216156

217157
- name: Mac_arm64 ios_platform_tests_shard_4 master - plugins
218-
bringup: true # New task; will replace Intel version
219158
recipe: plugins/plugins
220-
timeout: 60
159+
timeout: 120
221160
properties:
222161
add_recipes_cq: "true"
223162
version_file: flutter_master.version
224163
target_file: ios_platform_tests.yaml
225164
package_sharding: "--shardIndex 3 --shardCount 5"
226165

227166
- name: Mac_arm64 ios_platform_tests_shard_5 master - plugins
228-
bringup: true # New task; will replace Intel version
229167
recipe: plugins/plugins
230-
timeout: 60
168+
timeout: 120
231169
properties:
232170
add_recipes_cq: "true"
233171
version_file: flutter_master.version
234172
target_file: ios_platform_tests.yaml
235173
package_sharding: "--shardIndex 4 --shardCount 5"
236174

237175
# Don't run full platform tests on both channels in pre-submit.
238-
- name: Mac_x64 ios_platform_tests_1_of_4 stable
239-
recipe: plugins/plugins
240-
presubmit: false
241-
timeout: 60
242-
properties:
243-
channel: stable
244-
add_recipes_cq: "true"
245-
version_file: flutter_stable.version
246-
target_file: ios_platform_tests.yaml
247-
package_sharding: "--shardIndex 0 --shardCount 4"
248-
249-
- name: Mac_x64 ios_platform_tests_2_of_4 stable
250-
recipe: plugins/plugins
251-
presubmit: false
252-
timeout: 60
253-
properties:
254-
channel: stable
255-
add_recipes_cq: "true"
256-
version_file: flutter_stable.version
257-
target_file: ios_platform_tests.yaml
258-
package_sharding: "--shardIndex 1 --shardCount 4"
259-
260-
- name: Mac_x64 ios_platform_tests_3_of_4 stable
261-
recipe: plugins/plugins
262-
presubmit: false
263-
timeout: 60
264-
properties:
265-
channel: stable
266-
add_recipes_cq: "true"
267-
version_file: flutter_stable.version
268-
target_file: ios_platform_tests.yaml
269-
package_sharding: "--shardIndex 2 --shardCount 4"
270-
271-
- name: Mac_x64 ios_platform_tests_4_of_4 stable
272-
recipe: plugins/plugins
273-
presubmit: false
274-
timeout: 60
275-
properties:
276-
channel: stable
277-
add_recipes_cq: "true"
278-
version_file: flutter_stable.version
279-
target_file: ios_platform_tests.yaml
280-
package_sharding: "--shardIndex 3 --shardCount 4"
281-
282176
- name: Mac_arm64 ios_platform_tests_shard_1 stable - plugins
283-
bringup: true # New task; will replace Intel version
284177
recipe: plugins/plugins
285178
presubmit: false
286-
timeout: 60
179+
timeout: 120
287180
properties:
288181
channel: stable
289182
add_recipes_cq: "true"
@@ -292,10 +185,9 @@ targets:
292185
package_sharding: "--shardIndex 0 --shardCount 5"
293186

294187
- name: Mac_arm64 ios_platform_tests_shard_2 stable - plugins
295-
bringup: true # New task; will replace Intel version
296188
recipe: plugins/plugins
297189
presubmit: false
298-
timeout: 60
190+
timeout: 120
299191
properties:
300192
channel: stable
301193
add_recipes_cq: "true"
@@ -304,10 +196,9 @@ targets:
304196
package_sharding: "--shardIndex 1 --shardCount 5"
305197

306198
- name: Mac_arm64 ios_platform_tests_shard_3 stable - plugins
307-
bringup: true # New task; will replace Intel version
308199
recipe: plugins/plugins
309200
presubmit: false
310-
timeout: 60
201+
timeout: 120
311202
properties:
312203
channel: stable
313204
add_recipes_cq: "true"
@@ -316,10 +207,9 @@ targets:
316207
package_sharding: "--shardIndex 2 --shardCount 5"
317208

318209
- name: Mac_arm64 ios_platform_tests_shard_4 stable - plugins
319-
bringup: true # New task; will replace Intel version
320210
recipe: plugins/plugins
321211
presubmit: false
322-
timeout: 60
212+
timeout: 120
323213
properties:
324214
channel: stable
325215
add_recipes_cq: "true"
@@ -328,10 +218,9 @@ targets:
328218
package_sharding: "--shardIndex 3 --shardCount 5"
329219

330220
- name: Mac_arm64 ios_platform_tests_shard_5 stable - plugins
331-
bringup: true # New task; will replace Intel version
332221
recipe: plugins/plugins
333222
presubmit: false
334-
timeout: 60
223+
timeout: 120
335224
properties:
336225
channel: stable
337226
add_recipes_cq: "true"

0 commit comments

Comments
 (0)