Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit d7c8e70

Browse files
committed
Address review comments
1 parent 355b90e commit d7c8e70

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/video_player/video_player_web/lib/video_player_web.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ class VideoPlayerPlugin extends VideoPlayerPlatform {
3333
}
3434

3535
void _disposeAllPlayers() {
36-
_videoPlayers
37-
.forEach((_, _VideoPlayer videoPlayer) => videoPlayer.dispose());
36+
_videoPlayers.values
37+
.forEach((_VideoPlayer videoPlayer) => videoPlayer.dispose());
3838
_videoPlayers.clear();
3939
}
4040

@@ -114,9 +114,10 @@ class _VideoPlayer {
114114
..controls = false
115115
..style.border = 'none';
116116

117+
// TODO(hterkelsen): Use initialization parameters once they are available
117118
// ignore: undefined_prefixed_name
118119
ui.platformViewRegistry.registerViewFactory(
119-
textureId.toString(), (int viewId) => videoElement);
120+
'videoPlayer-$textureId', (int viewId) => videoElement);
120121

121122
videoElement.onCanPlay.listen((dynamic _) {
122123
if (!isInitialized) {

packages/video_player/video_player_web/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: video_player_web
22
description: Web platform implementation of video_player
33
author: Flutter Team <flutter-dev@googlegroups.com>
44
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web
5-
version: 0.0.1
5+
version: 0.1.0
66

77
flutter:
88
plugin:

0 commit comments

Comments
 (0)