Refactored 'Delegate' postfix according to latest discussion

Author: mvanbeusekom

packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/javascript_channel_registry.dart

@@ -14,26 +14,29 @@ import 'webview_platform.dart';
 /// The [WebViewControllerDelegate] is notifying this delegate on events that
 /// happened on the platform's webview. Platform implementations should
 /// implement this class and pass an instance to the [WebViewControllerDelegate].
-abstract class NavigationCallbackDelegate extends PlatformInterface {
-  /// Creates a new [NavigationCallbackDelegate]
-  factory NavigationCallbackDelegate(NavigationCallbackCreationParams params) {
-    final NavigationCallbackDelegate callbackDelegate =
-        WebViewPlatform.instance!.createNavigationCallbackDelegate(params);
+abstract class PlatformNavigationCallbackDelegate extends PlatformInterface {
+  /// Creates a new [PlatformNavigationCallbackDelegate]
+  factory PlatformNavigationCallbackDelegate(
+      PlatformNavigationCallbackDelegateCreationParams params) {
+    final PlatformNavigationCallbackDelegate callbackDelegate = WebViewPlatform
+        .instance!
+        .createPlatformNavigationCallbackDelegate(params);
     PlatformInterface.verify(callbackDelegate, _token);
     return callbackDelegate;
   }
 
-  /// Used by the platform implementation to create a new [NavigationCallbackDelegate].
+  /// Used by the platform implementation to create a new [PlatformNavigationCallbackDelegate].
   ///
   /// Should only be used by platform implementations because they can't extend
   /// a class that only contains a factory constructor.
   @protected
-  NavigationCallbackDelegate.implementation(this.params) : super(token: _token);
+  PlatformNavigationCallbackDelegate.implementation(this.params)
+      : super(token: _token);
 
   static final Object _token = Object();
 
-  /// The parameters used to initialize the [NavigationCallbackDelegate].
-  final NavigationCallbackCreationParams params;
+  /// The parameters used to initialize the [PlatformNavigationCallbackDelegate].
+  final PlatformNavigationCallbackDelegateCreationParams params;
 
   /// Invoked when a navigation request is pending.
   ///

…v4/src/navigation_callback_delegate.dart …atform_navigation_callback_delegate.dartpackages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/navigation_callback_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_navigation_callback_delegate.dart packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/navigation_callback_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_navigation_callback_delegate.dart

@@ -8,8 +8,7 @@ import 'dart:ui';
 import 'package:flutter/foundation.dart';
 import 'package:plugin_platform_interface/plugin_platform_interface.dart';
 
-import 'navigation_callback_delegate.dart';
-import 'types/types.dart';
+import 'platform_navigation_callback_delegate.dart';
 import 'webview_platform.dart';
 
 /// Interface for a platform implementation of a web view controller.
@@ -20,25 +19,25 @@ import 'webview_platform.dart';
 /// will get the default implementation, while platform implementations that
 /// `implements` this interface will be broken by newly added
 /// [WebViewCookieManagerDelegate] methods.
-abstract class WebViewControllerDelegate extends PlatformInterface {
-  /// Creates a new [WebViewControllerDelegate]
-  factory WebViewControllerDelegate(WebViewControllerCreationParams params) {
-    final WebViewControllerDelegate webViewControllerDelegate =
-        WebViewPlatform.instance!.createWebViewControllerDelegate(params);
+abstract class PlatformWebViewController extends PlatformInterface {
+  /// Creates a new [PlatformWebViewController]
+  factory PlatformWebViewController(WebViewControllerCreationParams params) {
+    final PlatformWebViewController webViewControllerDelegate =
+        WebViewPlatform.instance!.createPlatformWebViewController(params);
     PlatformInterface.verify(webViewControllerDelegate, _token);
     return webViewControllerDelegate;
   }
 
-  /// Used by the platform implementation to create a new [WebViewControllerDelegate].
+  /// Used by the platform implementation to create a new [PlatformWebViewController].
   ///
   /// Should only be used by platform implementations because they can't extend
   /// a class that only contains a factory constructor.
   @protected
-  WebViewControllerDelegate.implementation(this.params) : super(token: _token);
+  PlatformWebViewController.implementation(this.params) : super(token: _token);
 
   static final Object _token = Object();
 
-  /// The parameters used to initialize the [WebViewControllerDelegate].
+  /// The parameters used to initialize the [PlatformWebViewController].
   final WebViewControllerCreationParams params;
 
   /// Loads the file located on the specified [absoluteFilePath].
@@ -160,7 +159,7 @@ abstract class WebViewControllerDelegate extends PlatformInterface {
   /// Sets the [NavigationCallbackDelegate] containing the callback methods that
   /// are called during navigation events.
   Future<void> setNavigationCallbackDelegate(
-      NavigationCallbackDelegate handler) {
+      PlatformNavigationCallbackDelegate handler) {
     throw UnimplementedError(
         'setNavigationCallbackDelegate is not implemented on the current platform');
   }

…/v4/src/webview_controller_delegate.dart …/v4/src/platform_webview_controller.dartpackages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/webview_controller_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_webview_controller.dart packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/webview_controller_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_webview_controller.dart

@@ -5,7 +5,6 @@
 import 'package:flutter/foundation.dart';
 import 'package:plugin_platform_interface/plugin_platform_interface.dart';
 
-import 'types/types.dart';
 import 'webview_platform.dart';
 
 /// Interface for a platform implementation of a cookie manager.
@@ -15,30 +14,30 @@ import 'webview_platform.dart';
 /// changes. Extending this class (using `extends`) ensures that the subclass
 /// will get the default implementation, while platform implementations that
 /// `implements` this interface will be broken by newly added
-/// [WebViewCookieManagerDelegate] methods.
-abstract class WebViewCookieManagerDelegate extends PlatformInterface {
-  /// Creates a new [WebViewCookieManagerDelegate]
-  factory WebViewCookieManagerDelegate(
-      WebViewCookieManagerCreationParams params) {
-    final WebViewCookieManagerDelegate cookieManagerDelegate =
-        WebViewPlatform.instance!.createCookieManagerDelegate(params);
+/// [PlatformWebViewCookieManager] methods.
+abstract class PlatformWebViewCookieManager extends PlatformInterface {
+  /// Creates a new [PlatformWebViewCookieManager]
+  factory PlatformWebViewCookieManager(
+      PlatformWebViewCookieManagerCreationParams params) {
+    final PlatformWebViewCookieManager cookieManagerDelegate =
+        WebViewPlatform.instance!.createPlatformCookieManager(params);
     PlatformInterface.verify(cookieManagerDelegate, _token);
     return cookieManagerDelegate;
   }
 
   /// Used by the platform implementation to create a new
-  /// [WebViewCookieManagerDelegate].
+  /// [PlatformWebViewCookieManager].
   ///
   /// Should only be used by platform implementations because they can't extend
   /// a class that only contains a factory constructor.
   @protected
-  WebViewCookieManagerDelegate.implementation(this.params)
+  PlatformWebViewCookieManager.implementation(this.params)
       : super(token: _token);
 
   static final Object _token = Object();
 
-  /// The parameters used to initialize the [WebViewCookieManagerDelegate].
-  final WebViewCookieManagerCreationParams params;
+  /// The parameters used to initialize the [PlatformWebViewCookieManager].
+  final PlatformWebViewCookieManagerCreationParams params;
 
   /// Clears all cookies for all [WebView] instances.
   ///

…src/webview_cookie_manager_delegate.dart …src/platform_webview_cookie_manager.dartpackages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/webview_cookie_manager_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_webview_cookie_manager.dart packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/webview_cookie_manager_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_webview_cookie_manager.dart

@@ -2,34 +2,33 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'package:flutter/foundation.dart';
 import 'package:flutter/widgets.dart';
 import 'package:plugin_platform_interface/plugin_platform_interface.dart';
 
 import 'webview_platform.dart';
 
 /// Interface for a platform implementation of a web view widget.
-abstract class WebViewWidgetDelegate extends PlatformInterface {
-  /// Creates a new [WebViewWidgetDelegate]
-  factory WebViewWidgetDelegate(WebViewWidgetCreationParams params) {
-    final WebViewWidgetDelegate webViewWidgetDelegate =
+abstract class PlatformWebViewWidget extends PlatformInterface {
+  /// Creates a new [PlatformWebViewWidget]
+  factory PlatformWebViewWidget(PlatformWebViewWidgetCreationParams params) {
+    final PlatformWebViewWidget webViewWidgetDelegate =
         WebViewPlatform.instance!.createWebViewWidgetDelegate(params);
     PlatformInterface.verify(webViewWidgetDelegate, _token);
     return webViewWidgetDelegate;
   }
 
   /// Used by the platform implementation to create a new
-  /// [WebViewWidgetDelegate].
+  /// [PlatformWebViewWidget].
   ///
   /// Should only be used by platform implementations because they can't extend
   /// a class that only contains a factory constructor.
   @protected
-  WebViewWidgetDelegate.implementation(this.params) : super(token: _token);
+  PlatformWebViewWidget.implementation(this.params) : super(token: _token);
 
   static final Object _token = Object();
 
-  /// The parameters used to initialize the [WebViewWidgetDelegate].
-  final WebViewWidgetCreationParams params;
+  /// The parameters used to initialize the [PlatformWebViewWidget].
+  final PlatformWebViewWidgetCreationParams params;
 
   /// Builds a new WebView.
   ///

…/lib/v4/src/webview_widget_delegate.dart …/lib/v4/src/platform_webview_widget.dartpackages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/webview_widget_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_webview_widget.dart packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/webview_widget_delegate.dart renamed to packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/platform_webview_widget.dart

@@ -3,11 +3,12 @@
 // found in the LICENSE file.
 
 import 'dart:typed_data';
+
 import 'package:flutter/foundation.dart';
 
-import '../webview_controller_delegate.dart';
+import '../platform_webview_controller.dart';
 
-/// Defines the supported HTTP methods for loading a page in [WebViewControllerDelegate].
+/// Defines the supported HTTP methods for loading a page in [PlatformWebViewController].
 enum LoadRequestMethod {
   /// HTTP GET method.
   get,
@@ -29,7 +30,7 @@ extension LoadRequestMethodExtensions on LoadRequestMethod {
   }
 }
 
-/// Defines the parameters that can be used to load a page with the [WebViewControllerDelegate].
+/// Defines the parameters that can be used to load a page with the [PlatformWebViewController].
 ///
 /// Platform specific implementations can add additional fields by extending
 /// this class.

packages/webview_flutter/webview_flutter_platform_interface/lib/v4/src/types/javascript_channel.dart

@@ -0,0 +1,44 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'package:flutter/material.dart';
+
+/// Object specifying creation parameters for creating a [PlatformNavigationCallbackDelegate].
+///
+/// Platform specific implementations can add additional fields by extending
+/// this class.
+///
+/// {@tool sample}
+/// This example demonstrates how to extend the [PlatformNavigationCallbackDelegateCreationParams] to
+/// provide additional platform specific parameters.
+///
+/// When extending [PlatformNavigationCallbackDelegateCreationParams] additional
+/// parameters should always accept `null` or have a default value to prevent
+/// breaking changes.
+///
+/// ```dart
+/// class AndroidNavigationCallbackDelegateCreationParams extends PlatformNavigationCallbackDelegateCreationParams {
+///   AndroidNavigationCallbackDelegateCreationParams._(
+///     // This parameter prevents breaking changes later.
+///     // ignore: avoid_unused_constructor_parameters
+///     PlatformNavigationCallbackDelegateCreationParams params, {
+///     this.filter,
+///   }) : super();
+///
+///   factory AndroidNavigationCallbackDelegateCreationParams.fromPlatformNavigationCallbackDelegateCreationParams(
+///       PlatformNavigationCallbackDelegateCreationParams params, {
+///       String? filter,
+///   }) {
+///     return AndroidNavigationCallbackDelegateCreationParams._(params, filter: filter);
+///   }
+///
+///   final String? filter;
+/// }
+/// ```
+/// {@end-tool}
+@immutable
+class PlatformNavigationCallbackDelegateCreationParams {
+  /// Used by the platform implementation to create a new [PlatformNavigationCallbackDelegate].
+  const PlatformNavigationCallbackDelegateCreationParams();
+}