Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 6a7e313

Browse files
committed
Address review comments
1 parent 355b90e commit 6a7e313

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
## 0.0.1
1+
## 0.1.0
22

33
* Initial release

packages/video_player/video_player_web/lib/video_player_web.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'dart:async';
22
import 'dart:html';
33
import 'dart:ui' as ui;
4-
import 'dart:ui';
54

65
import 'package:flutter/material.dart';
76
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
@@ -33,8 +32,8 @@ class VideoPlayerPlugin extends VideoPlayerPlatform {
3332
}
3433

3534
void _disposeAllPlayers() {
36-
_videoPlayers
37-
.forEach((_, _VideoPlayer videoPlayer) => videoPlayer.dispose());
35+
_videoPlayers.values
36+
.forEach((_VideoPlayer videoPlayer) => videoPlayer.dispose());
3837
_videoPlayers.clear();
3938
}
4039

@@ -92,7 +91,7 @@ class VideoPlayerPlugin extends VideoPlayerPlatform {
9291

9392
@override
9493
Widget buildView(int textureId) {
95-
return HtmlElementView(viewType: textureId.toString());
94+
return HtmlElementView(viewType: 'videoPlayer-$textureId');
9695
}
9796
}
9897

@@ -114,9 +113,10 @@ class _VideoPlayer {
114113
..controls = false
115114
..style.border = 'none';
116115

116+
// TODO(hterkelsen): Use initialization parameters once they are available
117117
// ignore: undefined_prefixed_name
118118
ui.platformViewRegistry.registerViewFactory(
119-
textureId.toString(), (int viewId) => videoElement);
119+
'videoPlayer-$textureId', (int viewId) => videoElement);
120120

121121
videoElement.onCanPlay.listen((dynamic _) {
122122
if (!isInitialized) {

packages/video_player/video_player_web/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: video_player_web
22
description: Web platform implementation of video_player
33
author: Flutter Team <flutter-dev@googlegroups.com>
44
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_web
5-
version: 0.0.1
5+
version: 0.1.0
66

77
flutter:
88
plugin:

0 commit comments

Comments
 (0)