Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 48793cf

Browse files
authored
Shuffle text selection TODOs. (#911)
The double selection crash was fixed, but we are left with 2 other issues: * The text selection dialog is not responding to touches. * The text selection handles are not showing.
1 parent 8a8ccfb commit 48793cf

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

packages/webview_flutter/lib/webview_flutter.dart

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,13 @@ class _WebViewState extends State<WebView> {
7070
Widget build(BuildContext context) {
7171
if (defaultTargetPlatform == TargetPlatform.android) {
7272
return GestureDetector(
73-
// We prevent text selection by intercepting long press event.
74-
// This is a temporary workaround to prevent a native crash on a second
75-
// text selection.
76-
// TODO(amirh): remove this when the selection handles crash is resolved.
77-
// https://github.com/flutter/flutter/issues/21239
73+
// We prevent text selection by intercepting the long press event.
74+
// This is a temporary stop gap due to issues with text selection on Android:
75+
// https://github.com/flutter/flutter/issues/24585 - the text selection
76+
// dialog is not responding to touch events.
77+
// https://github.com/flutter/flutter/issues/24584 - the text selection
78+
// handles are not showing.
79+
// TODO(amirh): remove this when the issues above are fixed.
7880
onLongPress: () {},
7981
child: AndroidView(
8082
viewType: 'plugins.flutter.io/webview',

0 commit comments

Comments
 (0)