Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 3ec01e8

Browse files
ditmanditman
committed
[video_player_web] Move tests to integration_test style so they run in CI.
1 parent d100317 commit 3ec01e8

File tree

9 files changed

+161
-37
lines changed

9 files changed

+161
-37
lines changed

‎packages/video_player/video_player_web/example/README.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Testing
2+
3+
This package utilizes the `integration_test` package to run its tests in a web browser.
4+
5+
See [flutter.dev > Integration testing](https://flutter.dev/docs/testing/integration-tests) for more info.
6+
7+
## Running the tests
8+
9+
Make sure you have updated to the latest Flutter master.
10+
11+
1. Check what version of Chrome is running on the machine you're running tests on.
12+
13+
2. Download and install driver for that version from here:
14+
* <https://chromedriver.chromium.org/downloads>
15+
16+
3. Start the driver using `chromedriver --port=4444`
17+
18+
4. Run tests: `flutter drive -d web-server --browser-name=chrome --driver=test_driver/integration_driver.dart --target=integration_test/TEST_NAME.dart`, or (in Linux):
19+
20+
* Single: `./run_test.sh integration_test/TEST_NAME.dart`
21+
* All: `./run_test.sh`

‎packages/video_player/video_player_web/test/video_player_web_test.dart renamed to ‎packages/video_player/video_player_web/example/integration_test/video_player_web_test.dart

Lines changed: 34 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -2,39 +2,36 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@TestOn('browser')
6-
75
import 'dart:async';
86

97
import 'package:flutter/services.dart';
108
import 'package:flutter/widgets.dart';
119
import 'package:flutter_test/flutter_test.dart';
10+
import 'package:integration_test/integration_test.dart';
1211
import 'package:video_player_platform_interface/video_player_platform_interface.dart';
1312
import 'package:video_player_web/video_player_web.dart';
1413

1514
void main() {
15+
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
16+
1617
group('VideoPlayer for Web', () {
17-
late int textureId;
18+
late Future<int> textureId;
1819

19-
setUp(() async {
20+
setUp(() {
2021
VideoPlayerPlatform.instance = VideoPlayerPlugin();
21-
textureId = (await VideoPlayerPlatform.instance.create(
22+
textureId = VideoPlayerPlatform.instance.create(
2223
DataSource(
2324
sourceType: DataSourceType.network,
2425
uri:
2526
'https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4'),
26-
))!;
27-
});
28-
29-
test('$VideoPlayerPlugin is the live instance', () {
30-
expect(VideoPlayerPlatform.instance, isA<VideoPlayerPlugin>());
27+
).then((textureId) => textureId!);
3128
});
3229

33-
test('can init', () {
30+
testWidgets('can init', (WidgetTester tester) async {
3431
expect(VideoPlayerPlatform.instance.init(), completes);
3532
});
3633

37-
test('can create from network', () {
34+
testWidgets('can create from network', (WidgetTester tester) async {
3835
expect(
3936
VideoPlayerPlatform.instance.create(
4037
DataSource(
@@ -45,7 +42,7 @@ void main() {
4542
completion(isNonZero));
4643
});
4744

48-
test('can create from asset', () {
45+
testWidgets('can create from asset', (WidgetTester tester) async {
4946
expect(
5047
VideoPlayerPlatform.instance.create(
5148
DataSource(
@@ -57,7 +54,7 @@ void main() {
5754
completion(isNonZero));
5855
});
5956

60-
test('cannot create from file', () {
57+
testWidgets('cannot create from file', (WidgetTester tester) async {
6158
expect(
6259
VideoPlayerPlatform.instance.create(
6360
DataSource(
@@ -68,22 +65,22 @@ void main() {
6865
throwsUnimplementedError);
6966
});
7067

71-
test('can dispose', () {
72-
expect(VideoPlayerPlatform.instance.dispose(textureId), completes);
68+
testWidgets('can dispose', (WidgetTester tester) async {
69+
expect(VideoPlayerPlatform.instance.dispose(await textureId), completes);
7370
});
7471

75-
test('can set looping', () {
72+
testWidgets('can set looping', (WidgetTester tester) async {
7673
expect(
77-
VideoPlayerPlatform.instance.setLooping(textureId, true), completes);
74+
VideoPlayerPlatform.instance.setLooping(await textureId, true), completes);
7875
});
7976

80-
test('can play', () async {
77+
testWidgets('can play', (WidgetTester tester) async {
8178
// Mute video to allow autoplay (See https://goo.gl/xX8pDD)
82-
await VideoPlayerPlatform.instance.setVolume(textureId, 0);
83-
expect(VideoPlayerPlatform.instance.play(textureId), completes);
79+
await VideoPlayerPlatform.instance.setVolume(await textureId, 0);
80+
expect(VideoPlayerPlatform.instance.play(await textureId), completes);
8481
});
8582

86-
test('throws PlatformException when playing bad media', () async {
83+
testWidgets('throws PlatformException when playing bad media', (WidgetTester tester) async {
8784
int videoPlayerId = (await VideoPlayerPlatform.instance.create(
8885
DataSource(
8986
sourceType: DataSourceType.network,
@@ -103,43 +100,43 @@ void main() {
103100
}, throwsA(isA<PlatformException>()));
104101
});
105102

106-
test('can pause', () {
107-
expect(VideoPlayerPlatform.instance.pause(textureId), completes);
103+
testWidgets('can pause', (WidgetTester tester) async {
104+
expect(VideoPlayerPlatform.instance.pause(await textureId), completes);
108105
});
109106

110-
test('can set volume', () {
111-
expect(VideoPlayerPlatform.instance.setVolume(textureId, 0.8), completes);
107+
testWidgets('can set volume', (WidgetTester tester) async {
108+
expect(VideoPlayerPlatform.instance.setVolume(await textureId, 0.8), completes);
112109
});
113110

114-
test('can set playback speed', () {
111+
testWidgets('can set playback speed', (WidgetTester tester) async {
115112
expect(
116-
VideoPlayerPlatform.instance.setPlaybackSpeed(textureId, 2.0),
113+
VideoPlayerPlatform.instance.setPlaybackSpeed(await textureId, 2.0),
117114
completes,
118115
);
119116
});
120117

121-
test('can seek to position', () {
118+
testWidgets('can seek to position', (WidgetTester tester) async {
122119
expect(
123-
VideoPlayerPlatform.instance.seekTo(textureId, Duration(seconds: 1)),
120+
VideoPlayerPlatform.instance.seekTo(await textureId, Duration(seconds: 1)),
124121
completes);
125122
});
126123

127-
test('can get position', () {
128-
expect(VideoPlayerPlatform.instance.getPosition(textureId),
124+
testWidgets('can get position', (WidgetTester tester) async {
125+
expect(VideoPlayerPlatform.instance.getPosition(await textureId),
129126
completion(isInstanceOf<Duration>()));
130127
});
131128

132-
test('can get video event stream', () {
133-
expect(VideoPlayerPlatform.instance.videoEventsFor(textureId),
129+
testWidgets('can get video event stream', (WidgetTester tester) async {
130+
expect(VideoPlayerPlatform.instance.videoEventsFor(await textureId),
134131
isInstanceOf<Stream<VideoEvent>>());
135132
});
136133

137-
test('can build view', () {
138-
expect(VideoPlayerPlatform.instance.buildView(textureId),
134+
testWidgets('can build view', (WidgetTester tester) async {
135+
expect(VideoPlayerPlatform.instance.buildView(await textureId),
139136
isInstanceOf<Widget>());
140137
});
141138

142-
test('ignores setting mixWithOthers', () {
139+
testWidgets('ignores setting mixWithOthers', (WidgetTester tester) async {
143140
expect(VideoPlayerPlatform.instance.setMixWithOthers(true), completes);
144141
expect(VideoPlayerPlatform.instance.setMixWithOthers(false), completes);
145142
});

‎packages/video_player/video_player_web/example/lib/main.dart

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// Copyright 2013 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter/material.dart';
6+
7+
void main() {
8+
runApp(MyApp());
9+
}
10+
11+
/// App for testing
12+
class MyApp extends StatefulWidget {
13+
@override
14+
_MyAppState createState() => _MyAppState();
15+
}
16+
17+
class _MyAppState extends State<MyApp> {
18+
@override
19+
Widget build(BuildContext context) {
20+
return Directionality(
21+
textDirection: TextDirection.ltr,
22+
child: Text('Testing... Look at the console output for results!'),
23+
);
24+
}
25+
}

‎packages/video_player/video_player_web/example/pubspec.yaml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: connectivity_for_web_integration_tests
2+
publish_to: none
3+
4+
environment:
5+
sdk: ">=2.12.0 <3.0.0"
6+
flutter: ">=2.2.0"
7+
8+
dependencies:
9+
video_player_web:
10+
path: ../
11+
flutter:
12+
sdk: flutter
13+
14+
dev_dependencies:
15+
flutter_test:
16+
sdk: flutter
17+
flutter_driver:
18+
sdk: flutter
19+
integration_test:
20+
sdk: flutter

‎packages/video_player/video_player_web/example/run_test.sh

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
#!/usr/bin/bash
2+
# Copyright 2013 The Flutter Authors. All rights reserved.
3+
# Use of this source code is governed by a BSD-style license that can be
4+
# found in the LICENSE file.
5+
6+
if pgrep -lf chromedriver > /dev/null; then
7+
echo "chromedriver is running."
8+
9+
if [ $# -eq 0 ]; then
10+
echo "No target specified, running all tests..."
11+
find integration_test/ -iname *_test.dart | xargs -n1 -i -t flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target='{}'
12+
else
13+
echo "Running test target: $1..."
14+
set -x
15+
flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver=test_driver/integration_test.dart --target=$1
16+
fi
17+
18+
else
19+
echo "chromedriver is not running."
20+
echo "Please, check the README.md for instructions on how to use run_test.sh"
21+
fi
22+

‎packages/video_player/video_player_web/example/test_driver/integration_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
// Copyright 2013 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:integration_test/integration_test_driver.dart';
6+
7+
Future<void> main() => integrationDriver();

‎packages/video_player/video_player_web/example/web/index.html

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<!DOCTYPE html>
2+
<!-- Copyright 2013 The Flutter Authors. All rights reserved.
3+
Use of this source code is governed by a BSD-style license that can be
4+
found in the LICENSE file. -->
5+
<html>
6+
<head>
7+
<meta charset="UTF-8">
8+
<title>example</title>
9+
</head>
10+
<body>
11+
<script src="main.dart.js" type="application/javascript"></script>
12+
</body>
13+
</html>

‎packages/video_player/video_player_web/test/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
## test
2+
3+
This package uses integration tests for testing.
4+
5+
See `example/README.md` for more info.

‎packages/video_player/video_player_web/test/tests_exist_elsewhere_test.dart

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
// Copyright 2013 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_test/flutter_test.dart';
6+
7+
void main() {
8+
test('Tell the user where to find the real tests', () {
9+
print('---');
10+
print('This package uses integration_test for its tests.');
11+
print('See `example/README.md` for more info.');
12+
print('---');
13+
});
14+
}

0 commit comments

Comments
 (0)