Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 3c72094

Browse files
[video_player] Remove default method channel implementation (#6341)
Eliminates `MethodChannelVideoPlayer`, and instead makes the default a no-op subclass of the interface (i.e., one that throws `UnimplementedError` for everything). This moves the plugin from option 3 to option 2 in https://docs.flutter.dev/go/platform-channels-in-federated-plugins. This implementation is being removed because its use of Pigeon made ongoing maintenance impractical. Since default implementations are intended for backward compatibility with third-party native-only implementations, the platform channel internals of default implementations are considered part of the API surface. Pigeon considers those details implementation details, which means it was impossible to ever update the version of Pigeon used here without breaking changes. This means that fundamentally, Pigeon is not a viable choice for default implementations. The alternative to removing it would be replacing it with a new non-Pigeon method channel implementation, but that would also be a breaking change, defeating the purpose of backward compatibility. This would only benefit new third-party implementations, but new implementations should implement the platform interface rather than using the legacy default implementation. Fixes flutter/flutter#110017
1 parent 644d85b commit 3c72094

File tree

10 files changed

+27
-1280
lines changed

10 files changed

+27
-1280
lines changed

packages/video_player/video_player_platform_interface/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1-
## NEXT
1+
## 6.0.0
22

3+
* **BREAKING CHANGE**: Removes `MethodChannelVideoPlayer`. The default
4+
implementation is now only a placeholder with no functionality;
5+
implementations of `video_player` must include their own `VideoPlayerPlatform`
6+
Dart implementation.
37
* Updates minimum Flutter version to 2.10.
48
* Fixes violations of new analysis option use_named_constants.
59

packages/video_player/video_player_platform_interface/CONTRIBUTING.md

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)