Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 34d0aa5

Browse files
authored
[google_maps_flutter] fixed a small bug in example app. (#3590)
in _onMarkerTapped function we were changing markers[markerId] to defaultMarker and than again markers[markerId] to hueGreen marker, while instead we should have changed markers[selectedMarker] to defaultMarker first instead of markers[markerId]
1 parent b45875f commit 34d0aa5

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.0.0-nullsafety.1
2+
3+
* Fix in example app to properly change marker icon.
4+
15
## 2.0.0-nullsafety
26

37
* Migrate to null-safety

packages/google_maps_flutter/google_maps_flutter/example/lib/place_marker.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,11 @@ class PlaceMarkerBodyState extends State<PlaceMarkerBody> {
5353
final Marker? tappedMarker = markers[markerId];
5454
if (tappedMarker != null) {
5555
setState(() {
56-
if (markers.containsKey(markerId)) {
57-
final Marker resetOld = markers[markerId]!
56+
final MarkerId? previousMarkerId = selectedMarker;
57+
if (previousMarkerId != null && markers.containsKey(previousMarkerId)) {
58+
final Marker resetOld = markers[previousMarkerId]!
5859
.copyWith(iconParam: BitmapDescriptor.defaultMarker);
59-
markers[markerId] = resetOld;
60+
markers[previousMarkerId] = resetOld;
6061
}
6162
selectedMarker = markerId;
6263
final Marker newMarker = tappedMarker.copyWith(

packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: google_maps_flutter
22
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
33
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter/google_maps_flutter
4-
version: 2.0.0-nullsafety
4+
version: 2.0.0-nullsafety.1
55

66
dependencies:
77
flutter:

0 commit comments

Comments
 (0)