Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 3109073

Browse files
author
Casey Hillers
authored
[devicelab] Remove legacy devicelab manifest logic (#101554)
1 parent 2979ff6 commit 3109073

File tree

2 files changed

+0
-235
lines changed

2 files changed

+0
-235
lines changed

dev/devicelab/bin/run.dart

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import 'dart:io';
77

88
import 'package:args/args.dart';
99
import 'package:flutter_devicelab/framework/ab.dart';
10-
import 'package:flutter_devicelab/framework/manifest.dart';
1110
import 'package:flutter_devicelab/framework/runner.dart';
1211
import 'package:flutter_devicelab/framework/task_result.dart';
1312
import 'package:flutter_devicelab/framework/utils.dart';
@@ -63,16 +62,6 @@ Future<void> main(List<String> rawArgs) async {
6362
/// Path to write test results to.
6463
final String? resultsPath = args['results-file'] as String?;
6564

66-
if (!args.wasParsed('task')) {
67-
if (args.wasParsed('stage') || args.wasParsed('all')) {
68-
addTasks(
69-
tasks: loadTaskManifest().tasks,
70-
args: args,
71-
taskNames: taskNames,
72-
);
73-
}
74-
}
75-
7665
if (args.wasParsed('list')) {
7766
for (int i = 0; i < taskNames.length; i++) {
7867
print('${(i + 1).toString().padLeft(3)} - ${taskNames[i]}');
@@ -209,29 +198,6 @@ File _uniqueFile(String filenameTemplate) {
209198
return file;
210199
}
211200

212-
void addTasks({
213-
required List<ManifestTask> tasks,
214-
required ArgResults args,
215-
required List<String> taskNames,
216-
}) {
217-
if (args.wasParsed('continue-from')) {
218-
final int index = tasks.indexWhere((ManifestTask task) => task.name == args['continue-from']);
219-
if (index == -1) {
220-
throw Exception('Invalid task name "${args['continue-from']}"');
221-
}
222-
tasks.removeRange(0, index);
223-
}
224-
// Only start skipping if user specified a task to continue from
225-
final String stage = args['stage'] as String;
226-
for (final ManifestTask task in tasks) {
227-
final bool isQualifyingStage = stage == null || task.stage == stage;
228-
final bool isQualifyingHost = !(args['match-host-platform'] as bool) || task.isSupportedByHost();
229-
if (isQualifyingHost && isQualifyingStage) {
230-
taskNames.add(task.name);
231-
}
232-
}
233-
}
234-
235201
ArgParser createArgParser(List<String> taskNames) {
236202
return ArgParser()
237203
..addMultiOption(
@@ -293,16 +259,6 @@ ArgParser createArgParser(List<String> taskNames) {
293259
'The filename may contain a single # character to be replaced by a sequence\n'
294260
'number if the name already exists.',
295261
)
296-
..addFlag(
297-
'all',
298-
abbr: 'a',
299-
help: 'Runs all tasks defined in manifest.yaml in alphabetical order.',
300-
)
301-
..addOption(
302-
'continue-from',
303-
abbr: 'c',
304-
help: 'With --all or --stage, continue from the given test.',
305-
)
306262
..addFlag(
307263
'exit',
308264
defaultsTo: true,
@@ -352,12 +308,6 @@ ArgParser createArgParser(List<String> taskNames) {
352308
'service-account-token-file',
353309
help: '[Flutter infrastructure] Authentication for uploading results.',
354310
)
355-
..addOption(
356-
'stage',
357-
abbr: 's',
358-
help: 'Name of the stage. Runs all tasks for that stage. The tasks and\n'
359-
'their stages are read from manifest.yaml.',
360-
)
361311
..addFlag(
362312
'silent',
363313
help: 'Reduce verbosity slightly.',

dev/devicelab/lib/framework/manifest.dart

Lines changed: 0 additions & 185 deletions
This file was deleted.

0 commit comments

Comments
 (0)