Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 19ca7bd

Browse files
committed
Apply review feedback.
1 parent 9093887 commit 19ca7bd

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

packages/camera/camera/example/ios/RunnerTests/MockFLTThreadSafeFlutterResult.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
* The expectation is fullfilled when a result is called allowing tests to await the result in an
2020
* asynchronous manner.
2121
*/
22-
- (instancetype _Nonnull)initWithExpectation:(nonnull XCTestExpectation *)expectation;
22+
- (nonnull instancetype)initWithExpectation:(nonnull XCTestExpectation *)expectation;
2323
@end
2424

2525
#endif /* MockFLTThreadSafeFlutterResult_h */

packages/camera/camera/ios/Classes/CameraPlugin_Test.h

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,16 @@
1818
/// Hide the default public constructor.
1919
- (instancetype)init NS_UNAVAILABLE;
2020

21-
/// Exposes the [CameraPlugin handleMethodCallAsync:result:] method for unit testing.
22-
///
23-
/// This method should always be dispatched on a background queue to prevent deadlocks.
2421

22+
/// Handles `FlutterMethodCall`s and ensures result is send on the main dispatch queue.
23+
///
24+
/// @param call The method call command object.
25+
/// @param result A wrapper around the `FlutterResult` callback which ensures the callback is called on the main dispatch queue.
2526
- (void)handleMethodCallAsync:(FlutterMethodCall *)call result:(FLTThreadSafeFlutterResult *)result;
2627

27-
/// Exposes the [CameraPlugin orientationChanged:] method for unit testing.
28+
/// Called by the @c NSNotificationManager each time the device's orientation is changed.
29+
///
30+
/// @param notification @c NSNotification instance containing a reference to the `UIDevice` object that triggered the orientation change.
2831
- (void)orientationChanged:(NSNotification *)notification;
2932

3033
@end

0 commit comments

Comments
 (0)