Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 0683c05

Browse files
committed
Change getDirectoriesPaths to getDirectoryPaths and rebase.
1 parent 25c1bbb commit 0683c05

File tree

10 files changed

+27
-25
lines changed

10 files changed

+27
-25
lines changed

packages/file_selector/file_selector/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## 0.9.2+2
22

3-
* Adds `getDirectoriesPaths` method.
3+
* Adds `getDirectoryPaths` method.
44

55
## 0.9.2+1
66

packages/file_selector/file_selector/example/lib/get_multiple_directories_page.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
import 'package:file_selector/file_selector.dart';
66
import 'package:flutter/material.dart';
77

8-
/// Screen that allows the user to select one or more directories using `getDirectoriesPaths`,
8+
/// Screen that allows the user to select one or more directories using `getDirectoryPaths`,
99
/// then displays the selected directories in a dialog.
1010
class GetMultipleDirectoriesPage extends StatelessWidget {
1111
/// Default Constructor
1212
const GetMultipleDirectoriesPage({Key? key}) : super(key: key);
1313

1414
Future<void> _getDirectoryPaths(BuildContext context) async {
1515
const String confirmButtonText = 'Choose';
16-
final List<String?>? directoryPaths = await getDirectoriesPaths(
16+
final List<String?>? directoryPaths = await getDirectoryPaths(
1717
confirmButtonText: confirmButtonText,
1818
);
1919
if (directoryPaths == null) {

packages/file_selector/file_selector/lib/file_selector.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,10 @@ Future<String?> getDirectoryPath({
135135
/// When not provided, the default OS label is used (for example, "Open").
136136
///
137137
/// Returns `null` if the user cancels the operation.
138-
Future<List<String?>?> getDirectoriesPaths({
138+
Future<List<String?>?> getDirectoryPaths({
139139
String? initialDirectory,
140140
String? confirmButtonText,
141141
}) async {
142-
return FileSelectorPlatform.instance.getDirectoriesPaths(
142+
return FileSelectorPlatform.instance.getDirectoryPaths(
143143
initialDirectory: initialDirectory, confirmButtonText: confirmButtonText);
144144
}

packages/file_selector/file_selector/pubspec.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ description: Flutter plugin for opening and saving files, or selecting
44
repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/file_selector
55
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
66
version: 0.9.2+2
7+
# TODO(eugerossetto): This should be reverted once file_selector_platform_interface 2.3.0 is published.
8+
publish_to: 'none'
79

810
environment:
911
sdk: ">=2.12.0 <3.0.0"

packages/file_selector/file_selector/test/file_selector_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ void main() {
259259
});
260260
});
261261

262-
group('getDirectoriesPaths', () {
262+
group('getDirectoryPaths', () {
263263
const List<String> expectedDirectoryPaths = <String>[
264264
'/example/path',
265265
'/example/2/path'
@@ -272,7 +272,7 @@ void main() {
272272
confirmButtonText: confirmButtonText)
273273
..setPathsResponse(expectedDirectoryPaths);
274274

275-
final List<String?>? directoryPaths = await getDirectoriesPaths(
275+
final List<String?>? directoryPaths = await getDirectoryPaths(
276276
initialDirectory: initialDirectory,
277277
confirmButtonText: confirmButtonText,
278278
);
@@ -283,7 +283,7 @@ void main() {
283283
test('works with no arguments', () async {
284284
fakePlatformImplementation.setPathsResponse(expectedDirectoryPaths);
285285

286-
final List<String?>? directoryPaths = await getDirectoriesPaths();
286+
final List<String?>? directoryPaths = await getDirectoryPaths();
287287
expect(directoryPaths, expectedDirectoryPaths);
288288
});
289289

@@ -293,7 +293,7 @@ void main() {
293293
..setPathsResponse(expectedDirectoryPaths);
294294

295295
final List<String?>? directoryPaths =
296-
await getDirectoriesPaths(initialDirectory: initialDirectory);
296+
await getDirectoryPaths(initialDirectory: initialDirectory);
297297
expect(directoryPaths, expectedDirectoryPaths);
298298
});
299299

@@ -303,7 +303,7 @@ void main() {
303303
..setPathsResponse(expectedDirectoryPaths);
304304

305305
final List<String?>? directoryPaths =
306-
await getDirectoriesPaths(confirmButtonText: confirmButtonText);
306+
await getDirectoryPaths(confirmButtonText: confirmButtonText);
307307
expect(directoryPaths, expectedDirectoryPaths);
308308
});
309309
});
@@ -398,7 +398,7 @@ class FakeFileSelector extends Fake
398398
}
399399

400400
@override
401-
Future<List<String>?> getDirectoriesPaths({
401+
Future<List<String>?> getDirectoryPaths({
402402
String? initialDirectory,
403403
String? confirmButtonText,
404404
}) async {

packages/file_selector/file_selector_platform_interface/CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
## 2.3.0
1+
## 2.4.0
22

3-
* Replaces `macUTIs` with `uniformTypeIdentifiers`. `macUTIs` is available as an alias, but will be deprecated in a future release.
3+
* Adds `getDirectoryPaths` method to the interface.
44

5-
## 2.2.0+1
5+
## 2.3.0
66

7-
* Adds getDirectoriesPaths method to the interface.
7+
* Replaces `macUTIs` with `uniformTypeIdentifiers`. `macUTIs` is available as an alias, but will be deprecated in a future release.
88

99
## 2.2.0
1010

packages/file_selector/file_selector_platform_interface/lib/src/method_channel/method_channel_file_selector.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,10 @@ class MethodChannelFileSelector extends FileSelectorPlatform {
9696

9797
/// Gets a list of directories paths from a dialog
9898
@override
99-
Future<List<String>?> getDirectoriesPaths(
99+
Future<List<String>?> getDirectoryPaths(
100100
{String? initialDirectory, String? confirmButtonText}) async {
101101
return _channel.invokeListMethod<String>(
102-
'getDirectoriesPaths',
102+
'getDirectoryPaths',
103103
<String, dynamic>{
104104
'initialDirectory': initialDirectory,
105105
'confirmButtonText': confirmButtonText,

packages/file_selector/file_selector_platform_interface/lib/src/platform_interface/file_selector_interface.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ abstract class FileSelectorPlatform extends PlatformInterface {
7777

7878
/// Open file dialog for loading directories and return multiple directories paths
7979
/// Returns `null` if user cancels the operation.
80-
Future<List<String>?> getDirectoriesPaths({
80+
Future<List<String>?> getDirectoryPaths({
8181
String? initialDirectory,
8282
String? confirmButtonText,
8383
}) {
84-
throw UnimplementedError('getDirectoriesPaths() has not been implemented.');
84+
throw UnimplementedError('getDirectoryPaths() has not been implemented.');
8585
}
8686
}

packages/file_selector/file_selector_platform_interface/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ repository: https://github.com/flutter/plugins/tree/main/packages/file_selector/
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
55
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
66
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
7-
version: 2.3.0
7+
version: 2.4.0
88

99
environment:
1010
sdk: ">=2.12.0 <3.0.0"

packages/file_selector/file_selector_platform_interface/test/method_channel_file_selector_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -247,15 +247,15 @@ void main() {
247247
);
248248
});
249249
});
250-
group('#getDirectoriesPaths', () {
250+
group('#getDirectoryPaths', () {
251251
test('passes initialDirectory correctly', () async {
252-
await plugin.getDirectoriesPaths(
252+
await plugin.getDirectoryPaths(
253253
initialDirectory: '/example/directory');
254254

255255
expect(
256256
log,
257257
<Matcher>[
258-
isMethodCall('getDirectoriesPaths', arguments: <String, dynamic>{
258+
isMethodCall('getDirectoryPaths', arguments: <String, dynamic>{
259259
'initialDirectory': '/example/directory',
260260
'confirmButtonText': null,
261261
'multiple': true
@@ -264,12 +264,12 @@ void main() {
264264
);
265265
});
266266
test('passes confirmButtonText correctly', () async {
267-
await plugin.getDirectoriesPaths(confirmButtonText: 'Open File');
267+
await plugin.getDirectoryPaths(confirmButtonText: 'Open File');
268268

269269
expect(
270270
log,
271271
<Matcher>[
272-
isMethodCall('getDirectoriesPaths', arguments: <String, dynamic>{
272+
isMethodCall('getDirectoryPaths', arguments: <String, dynamic>{
273273
'initialDirectory': null,
274274
'confirmButtonText': 'Open File',
275275
'multiple': true

0 commit comments

Comments
 (0)