Skip to content

[interactive_media_ads] Adds wrappers for native IMA settings #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 1, 2025

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jun 24, 2025

IMASettings.enabledBackgroundPlayback is needed to add support for flutter/flutter#153447 on iOS.

This just adds all the flags for IMASettings and ImaSdkSettings for both platforms.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title Ima settings [interactive_media_ads] Adds wrapper for native IMA settings Jun 24, 2025
@bparrishMines bparrishMines marked this pull request as ready for review June 24, 2025 19:59
@bparrishMines bparrishMines changed the title [interactive_media_ads] Adds wrapper for native IMA settings [interactive_media_ads] Adds wrappers for native IMA settings Jun 24, 2025
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025
@auto-submit auto-submit bot merged commit 495beb2 into flutter:main Jul 1, 2025
78 checks passed
@bparrishMines bparrishMines deleted the ima_settings branch July 1, 2025 20:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jul 2, 2025
flutter/packages@3dc682d...205c50f

2025-07-01 stuartmorgan@google.com [google_sign_in] Add
`GoogleSignInExceptionCode` export (flutter/packages#9545)
2025-07-01 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds wrappers for native IMA settings
(flutter/packages#9481)
2025-07-01 47866232+chunhtai@users.noreply.github.com [go_router] bump
breaking change release to v16 (flutter/packages#9480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…r#171526)

flutter/packages@3dc682d...205c50f

2025-07-01 stuartmorgan@google.com [google_sign_in] Add
`GoogleSignInExceptionCode` export (flutter/packages#9545)
2025-07-01 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds wrappers for native IMA settings
(flutter/packages#9481)
2025-07-01 47866232+chunhtai@users.noreply.github.com [go_router] bump
breaking change release to v16 (flutter/packages#9480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants