Roll Flutter master to 824868f5d1e6c091a5df23d3628407e75149e1da #9416
Conversation
|
Android failures are probably flutter/flutter#169884 |
|
Trying the emulator version from flutter/flutter#158017, which it looks like at least some flutter/flutter configs are still using. |
|
Wait, that's the version we're already using. Now I'm confused. @reidbaker Any idea why we're getting emulator failures suggesting we're using x86 emulators if the |
|
Oh, never mind, it's the legacy tests that are failing, so the issue is |
|
Hm, it looks from https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/android/avd/proto like API 30 or 31 is the oldest we can now go with the "legacy" tests. We're going to lose a lot of safety about continuing to work on older versions of Android. |
stuartmorgan-g
force-pushed
the
manual-roll-824868f5d1e6
branch
from
db65153 to
4337bc7
Compare
|
@reidbaker Do you have any better ideas than us making API 31 our "old" test device? |
(The counterpoint is that I don't think we've actually had many cases of things that only failed these tests.) |
|
Is 31 the oldest device that has a non x86 image? If you haven't checked then I can. |
|
From the link above, the only older one I can find is |
|
Our only other option would be authoring one of those proto files and getting chromium to accept it. https://github.com/chromium/chromium/blob/main/docs%2Fandroid_emulator.md |
|
In that case, since the roller is currently over a week behind and this is a blocker, I would like to land this rather than block for an unknown amount of time. Any objection to that? Should I file a |
|
No objection to setting the old tests to api 31 |
stuartmorgan-g
added
the
autosubmit
|
Thanks! I filed flutter/flutter#170474 to make sure we don't forget to at least consider adjusting it later. |
flutter/packages@0b322a2...6d3aaf4 2025-06-11 stuartmorgan@google.com Roll Flutter master to 824868f (flutter/packages#9416) 2025-06-11 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for companion ads (flutter/packages#9260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ter#9416) Rolls Flutter master version to 824868f5d1e6c091a5df23d3628407e75149e1da flutter/flutter@2d9977c...824868f
…r#170528) flutter/packages@0b322a2...6d3aaf4 2025-06-11 stuartmorgan@google.com Roll Flutter master to 824868f (flutter/packages#9416) 2025-06-11 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for companion ads (flutter/packages#9260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ter#9416) Rolls Flutter master version to 824868f5d1e6c091a5df23d3628407e75149e1da flutter/flutter@2d9977c...824868f
Rolls Flutter master version to 824868f5d1e6c091a5df23d3628407e75149e1da
flutter/flutter@2d9977c...824868f