[gis_web] Make maybeEnum more robust in google_identity_services_web shared file. #8999
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks Vikash, I reached out to you internally with next steps that are only relevant for Googlers. |
…js file to pass moment notification from test directly.
There was a problem hiding this comment.
LGTM, but @ditman or another web reviewer should provide the second approval.
| if (value.name == needle) { | ||
| return value; | ||
| } | ||
| } |
There was a problem hiding this comment.
A future improvement may be to log a warning or similar when we attempt to decode a value of T that will return null, so people can report bugs. We'll see if that becomes a problem later.
…vices_web shared file. (flutter/packages#8999)
…vices_web shared file. (flutter/packages#8999)
flutter/packages@f1fc965...41211cf 2025-04-22 11042814+vikdubey@users.noreply.github.com [gis_web] Make maybeEnum more robust in google_identity_services_web shared file. (flutter/packages#8999) 2025-04-22 sokolovskyi.konstantin@gmail.com [video_player_web] Fix blank first frame on iOS. (flutter/packages#9025) 2025-04-22 32538273+ValentinVignal@users.noreply.github.com [go_router] Add missing `caseSensitive` parameter to `GoRouteData.$route` (flutter/packages#9126) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…shared file. (flutter#8999) When the needle value is unexpected, instead of throwing error, it'll return null now. Fixes flutter/flutter#166548 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…shared file. (flutter#8999) When the needle value is unexpected, instead of throwing error, it'll return null now. Fixes flutter/flutter#166548 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…shared file. (flutter#8999) When the needle value is unexpected, instead of throwing error, it'll return null now. Fixes flutter/flutter#166548 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
When the needle value is unexpected, instead of throwing error, it'll return null now.
Fixes flutter/flutter#166548
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3