[google_maps_flutter] Fix iOS info window regression #8939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced during the migration to structured Pigeon data, where the info window data was not passed through to the underlying SDK marker object. This wasn't caught because there was apparently no native unit testing of marker properties, and this level of info window detail isn't inspected in integration tests. Adds missing tests, and backfills tests for other marker properties as well. Fixes flutter/flutter#159471
stuartmorgan-g
commented
Mar 31, 2025
| [self setZIndex:platformMarker.zIndex]; | ||
| } | ||
|
|
||
| - (void)interpretInfoWindow:(NSDictionary *)data { |
There was a problem hiding this comment.
This was dead code; I accidentally dropped the call to this method when converting the method above, instead of updating it (and folding it in as I've now done, since it's no longer complex enough to benefit from a separate method). That dropped call was the source of the regression.
| @interface FLTGoogleMapMarkerController (Test) | ||
|
|
||
| /// Extracts an icon image from the iconData array. |
There was a problem hiding this comment.
Both of these were dead code; they were exposing helpers that no longer exist in this class, and are instead stand-alone functions in a util file that are tested directly. I just missed this cleanup when converting them.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2025
flutter/packages@07496eb...4a36dc6 2025-04-03 1063596+reidbaker@users.noreply.github.com [all_packages] Enforce property assignment for compile sdk over method assignment (flutter/packages#8897) 2025-04-03 stuartmorgan@google.com [google_maps_flutter] Fix iOS info window regression (flutter/packages#8939) 2025-04-02 engine-flutter-autoroll@skia.org Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter/packages#8985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
masterromuald
pushed a commit
to masterromuald/packages
that referenced
this pull request
Apr 3, 2025
Fixes a regression introduced during the migration to structured Pigeon data (flutter#8142), where the info window data was not passed through to the underlying SDK marker object. This wasn't caught because there was apparently no native unit testing of marker properties, and this level of info window detail isn't inspected in integration tests. Adds missing tests, and backfills tests for other marker properties as well. Fixes flutter/flutter#159471 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Fixes a regression introduced during the migration to structured Pigeon data (flutter#8142), where the info window data was not passed through to the underlying SDK marker object. This wasn't caught because there was apparently no native unit testing of marker properties, and this level of info window detail isn't inspected in integration tests. Adds missing tests, and backfills tests for other marker properties as well. Fixes flutter/flutter#159471 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…r#166542) flutter/packages@07496eb...4a36dc6 2025-04-03 1063596+reidbaker@users.noreply.github.com [all_packages] Enforce property assignment for compile sdk over method assignment (flutter/packages#8897) 2025-04-03 stuartmorgan@google.com [google_maps_flutter] Fix iOS info window regression (flutter/packages#8939) 2025-04-02 engine-flutter-autoroll@skia.org Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter/packages#8985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Fixes a regression introduced during the migration to structured Pigeon data (flutter#8142), where the info window data was not passed through to the underlying SDK marker object. This wasn't caught because there was apparently no native unit testing of marker properties, and this level of info window detail isn't inspected in integration tests. Adds missing tests, and backfills tests for other marker properties as well. Fixes flutter/flutter#159471 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced during the migration to structured Pigeon data (#8142), where the info window data was not passed through to the underlying SDK marker object. This wasn't caught because there was apparently no native unit testing of marker properties, and this level of info window detail isn't inspected in integration tests.
Adds missing tests, and backfills tests for other marker properties as well.
Fixes flutter/flutter#159471
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3