[camera_avfoundation] Tests backfilling - part 5 #8873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertOdrowaz
force-pushed
the
feature/camera-tests-backfilling-part5
branch
from
0480dd2 to
18cb936
Compare
RobertOdrowaz
force-pushed
the
feature/camera-tests-backfilling-part5
branch
from
18cb936 to
341d896
Compare
hellohuanlin
approved these changes
Mar 18, 2025
| ## 0.9.18+10 | ||
|
|
||
| * Backfills unit tests for the `FLTCam` class. | ||
| * Makes `exposureMode`, `focusMode`, and `flashMode` properties of `FLTCam` private. |
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 19, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 19, 2025
flutter/packages@d450e1b...dd781d4 2025-03-19 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 4 (flutter/packages#8854) 2025-03-18 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 5 (flutter/packages#8873) 2025-03-18 zezohassam@gmail.com [video_player]: reduce video player position update interval from 500ms to 100ms (flutter/packages#8346) 2025-03-18 joonas.kerttula@codemate.com [google_maps_flutter] Support for Ground Overlay (flutter/packages#8432) 2025-03-18 joonas.kerttula@codemate.com [google_maps_flutter] Ground overlay support - platform impls (flutter/packages#8563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Backfills tests for the FLTCam class as part of flutter/flutter#119109 Adds tests for the `setExposureMode` and zoom-related methods of the `FLTCam` class. Modifies tests for focus mode to test the `setFocusMode` method instead of `applyFocusMode` because it's actually used by `CameraPlugin`. There is also a small refactor to make `exposureMode`, `focusMode`, and `flashMode` properties private since they are never access directly. ## Pre-Review Checklist
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…r#165489) flutter/packages@d450e1b...dd781d4 2025-03-19 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 4 (flutter/packages#8854) 2025-03-18 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 5 (flutter/packages#8873) 2025-03-18 zezohassam@gmail.com [video_player]: reduce video player position update interval from 500ms to 100ms (flutter/packages#8346) 2025-03-18 joonas.kerttula@codemate.com [google_maps_flutter] Support for Ground Overlay (flutter/packages#8432) 2025-03-18 joonas.kerttula@codemate.com [google_maps_flutter] Ground overlay support - platform impls (flutter/packages#8563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Backfills tests for the FLTCam class as part of flutter/flutter#119109 Adds tests for the `setExposureMode` and zoom-related methods of the `FLTCam` class. Modifies tests for focus mode to test the `setFocusMode` method instead of `applyFocusMode` because it's actually used by `CameraPlugin`. There is also a small refactor to make `exposureMode`, `focusMode`, and `flashMode` properties private since they are never access directly. ## Pre-Review Checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backfills tests for the FLTCam class as part of flutter/flutter#119109
Adds tests for the
setExposureModeand zoom-related methods of theFLTCamclass. Modifies tests for focus mode to test thesetFocusModemethod instead ofapplyFocusModebecause it's actually used byCameraPlugin. There is also a small refactor to makeexposureMode,focusMode, andflashModeproperties private since they are never access directly.Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.