Skip to content

[flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 #8760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Feb 28, 2025

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

…for 35 to support flutter versions prior to 3.27
…mps minimum flutter version to 3.27 (first version to have support)
@reidbaker
Copy link
Contributor Author

Keeping in draft until a test can be added to gradle-check

@stuartmorgan-g
Copy link
Contributor

#8761 will add the safety check.

@reidbaker reidbaker marked this pull request as ready for review February 28, 2025 16:48
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you should merge in main to get the new check, just to be safe

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2025
@auto-submit auto-submit bot merged commit 89135e7 into flutter:main Mar 3, 2025
82 checks passed
@reidbaker reidbaker deleted the i149836-api-35-update-part-13-reland-lifecycle branch March 3, 2025 18:23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 5, 2025
flutter/packages@9e4684e...abba683

2025-03-05 robert.odrowaz@leancode.pl [camera_avfoundation] Tests
backfilling - part 1 (flutter/packages#8698)
2025-03-04 57854043+CaoGiaHieu-dev@users.noreply.github.com
[go_router_builder]: Fix `The argument type 'String?' can't be assigned
to the parameter type 'String' because 'String?' ` on path and query
params (flutter/packages#8737)
2025-03-04 pawel.jakubowski@leancode.pl [video_player_android] Platform
view support (flutter/packages#8466)
2025-03-04 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request`
(flutter/packages#8766)
2025-03-03 engine-flutter-autoroll@skia.org Manual roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8775)
2025-03-03 engine-flutter-autoroll@skia.org Roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8774)
2025-03-03 reidbaker@google.com [flutter_plugin_android_lifecycle] Uses
flutter.compileSdkVersion, bumps minimum flutter version to 3.27
(flutter/packages#8760)
2025-03-03 neilself@gmail.com [google_sign_in] Add Android account name
field as optional (platform interface changes) (flutter/packages#8735)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
…mps minimum flutter version to 3.27 (flutter#8760)

- **[flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (first version to have support)**
related to flutter/flutter/issues/149836 
Functionally a reland of flutter#8700 after the "revert" in flutter#8758
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…mps minimum flutter version to 3.27 (flutter#8760)

- **[flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (first version to have support)**
related to flutter/flutter/issues/149836 
Functionally a reland of flutter#8700 after the "revert" in flutter#8758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_plugin_android_lifecycle platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants