[google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry #8754

filiph · 2025-02-28T11:37:41Z

Two issues caught by @jokerttu after #8560 was already merged:

a typo ("iOS-specific" --> "web-specific")
a forgotten changelog entry

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g · 2025-02-28T19:25:00Z

I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.

I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.

These steps still need to be done.

stuartmorgan-g

(The above was meant to be a change request.)

This reverts commit 58d1eef.

filiph · 2025-03-06T10:01:48Z

These steps still need to be done.

Done.

stuartmorgan-g

LGTM with a changelog correction.

stuartmorgan-g · 2025-03-06T15:47:00Z

packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.10.2
+
+* Fixes typos in README and CHANGELOG.


Nit: the typo is only in the README. There is no CHANGELOG fix in this package.

Ok, I just ran dart run script/tool/bin/flutter_plugin_tools.dart update-release-info --version=minimal --base-branch=upstream/main --changelog="Fixes typos in README and CHANGELOG." I expected the change message to be put in both packages that were modified. I'm guessing the update-release-info tool is smarter and it ignores CHANGELOG changes?

Do you want me to:

a) Force an update to google_maps_flutter_platform_interface, or
b) Merely change "Fixes typos in README and CHANGELOG" above to "Fixes typo in README"?

I'm guessing the update-release-info tool is smarter and it ignores CHANGELOG changes?

Correct.

b) Merely change "Fixes typos in README and CHANGELOG" above to "Fixes typo in README"?

This one. The trivial issue in the other CHANGELOG will be cleaned up on the next publish, and isn't worth releasing a new version for.

Got it, and thanks for your patience with me. Change pushed now.

stuartmorgan-g · 2025-03-25T19:59:56Z

From triage: It looks like this just needs conflicts resolved and then to be landed?

filiph · 2025-03-26T10:24:54Z

I've resolved the conflicts.

…ELOG entry (flutter/packages#8754)

@jokerttu

…flutter#8754) Two issues caught by @jokerttu after flutter#8560 was already merged: - a typo ("iOS-specific" --> "web-specific") - a forgotten changelog entry

…ELOG entry (flutter/packages#8754)

flutter/packages@125c117...07496eb 2025-04-02 alexander.irion@siemens.com [multicast_dns] MDnsClient::listen supports onError callback (flutter/packages#8888) 2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to use Xcode 16 and iOS 18 (flutter/packages#8968) 2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960) 2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head meta tags (flutter/packages#8970) 2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter discussion (flutter/packages#8924) 2025-04-01 stuartmorgan@google.com Update CODEOWNERS username (flutter/packages#8933) 2025-04-01 69054810+M97Chahboun@users.noreply.github.com [flutter_markdown] Added sizedImageBuilder to Markdown widget (flutter/packages#6739) 2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy of iOS tests (flutter/packages#8975) 2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more hanging iOS tests (flutter/packages#8967) 2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. (flutter/packages#8582) 2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils and mocks swift migration - part 2 (flutter/packages#8892) 2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter] Skip flaky legacy tests on iOS (flutter/packages#8911) 2025-03-31 davidmartos96@gmail.com [camera_android] Don't override default fps range when not recording (flutter/packages#8891) 2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry (flutter/packages#8754) 2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the latest version of googleapis_auth (flutter/packages#8931) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8955) 2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash when sending undefined message via javascript channel (flutter/packages#8776) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#8946) 2025-03-31 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in release mode (flutter/packages#8918) 2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that hangs iOS CI (flutter/packages#8958) 2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter/packages#8922) 2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils and mocks swift migration - part 3 (flutter/packages#8912) 2025-03-27 jacksongardner@google.com Use a more deterministic way of waiting for ad widgets to be ready. (flutter/packages#8920) 2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils and mocks swift migration - part 1 (flutter/packages#8890) 2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended generics in generator methods (flutter/packages#8910) 2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix layout issue caused by `Transform.rotate` not affecting space calculation. (flutter/packages#8685) 2025-03-27 43759233+kenzieschmoll@users.noreply.github.com [shared_preferences] Fix a late initialized error with the example app (flutter/packages#8540) 2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome dart tests (flutter/packages#8909) 2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to base command class (flutter/packages#8730) 2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens type information (iOS) (flutter/packages#8723) 2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods (flutter/packages#8887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

…ELOG entry (flutter/packages#8754)

@jokerttu

…flutter#8754) Two issues caught by @jokerttu after flutter#8560 was already merged: - a typo ("iOS-specific" --> "web-specific") - a forgotten changelog entry

…er#166457) flutter/packages@125c117...07496eb 2025-04-02 alexander.irion@siemens.com [multicast_dns] MDnsClient::listen supports onError callback (flutter/packages#8888) 2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to use Xcode 16 and iOS 18 (flutter/packages#8968) 2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter/packages#8960) 2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head meta tags (flutter/packages#8970) 2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter discussion (flutter/packages#8924) 2025-04-01 stuartmorgan@google.com Update CODEOWNERS username (flutter/packages#8933) 2025-04-01 69054810+M97Chahboun@users.noreply.github.com [flutter_markdown] Added sizedImageBuilder to Markdown widget (flutter/packages#6739) 2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy of iOS tests (flutter/packages#8975) 2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more hanging iOS tests (flutter/packages#8967) 2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded, clicking close causes the callback to not be triggered correctly. (flutter/packages#8582) 2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils and mocks swift migration - part 2 (flutter/packages#8892) 2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter] Skip flaky legacy tests on iOS (flutter/packages#8911) 2025-03-31 davidmartos96@gmail.com [camera_android] Don't override default fps range when not recording (flutter/packages#8891) 2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry (flutter/packages#8754) 2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the latest version of googleapis_auth (flutter/packages#8931) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#8955) 2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash when sending undefined message via javascript channel (flutter/packages#8776) 2025-03-31 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#8946) 2025-03-31 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in release mode (flutter/packages#8918) 2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that hangs iOS CI (flutter/packages#8958) 2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter/packages#8922) 2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils and mocks swift migration - part 3 (flutter/packages#8912) 2025-03-27 jacksongardner@google.com Use a more deterministic way of waiting for ad widgets to be ready. (flutter/packages#8920) 2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils and mocks swift migration - part 1 (flutter/packages#8890) 2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended generics in generator methods (flutter/packages#8910) 2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix layout issue caused by `Transform.rotate` not affecting space calculation. (flutter/packages#8685) 2025-03-27 43759233+kenzieschmoll@users.noreply.github.com [shared_preferences] Fix a late initialized error with the example app (flutter/packages#8540) 2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome dart tests (flutter/packages#8909) 2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to base command class (flutter/packages#8730) 2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens type information (iOS) (flutter/packages#8723) 2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods (flutter/packages#8887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

@jokerttu

…flutter#8754) Two issues caught by @jokerttu after flutter#8560 was already merged: - a typo ("iOS-specific" --> "web-specific") - a forgotten changelog entry

filiph requested a review from stuartmorgan-g as a code owner February 28, 2025 11:37

github-actions bot added the p: google_maps_flutter label Feb 28, 2025

filiph mentioned this pull request Feb 28, 2025

[google_maps_flutter] Improve README and API doc comments #8560

Merged

11 tasks

stuartmorgan-g requested changes Feb 28, 2025

View reviewed changes

Fix typo and remove duplicitous CHANGELOG entry

7a6ad48

filiph force-pushed the fix/typo branch from d66d74f to 7a6ad48 Compare March 6, 2025 09:47

filiph added 3 commits March 6, 2025 10:51

Update CHANGELOGs

58d1eef

Revert "Update CHANGELOGs"

cb6b5cb

This reverts commit 58d1eef.

Run update-release-info

4463f5d

stuartmorgan-g approved these changes Mar 6, 2025

View reviewed changes

Fix CHANGELOG message

cd9c1b7

Merge branch 'main' into fix/typo

2364de5

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025

auto-submit bot merged commit 01f9771 into flutter:main Mar 31, 2025
82 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

423bd63

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll mentioned this pull request Mar 31, 2025

Roll Packages from 125c117a432f to 01f977156055 (18 revisions) flutter/flutter#166261

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

8849314

…ELOG entry (flutter/packages#8754)

This was referenced Mar 31, 2025

Roll Packages from 125c117a432f to c97691715ffb (19 revisions) flutter/flutter#166266

Closed

Roll Packages from 125c117a432f to c97691715ffb (19 revisions) flutter/flutter#166280

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

5d1ba2a

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

12d0d7b

…ELOG entry (flutter/packages#8754)

This was referenced Apr 1, 2025

Roll Packages from 125c117a432f to 0ef3d446fd44 (23 revisions) flutter/flutter#166341

Closed

Roll Packages from 125c117a432f to 799a5908904c (24 revisions) flutter/flutter#166346

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

115f8ec

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

a5bc6fa

…ELOG entry (flutter/packages#8754)

This was referenced Apr 1, 2025

Roll Packages from 125c117a432f to bba066f89dd4 (25 revisions) flutter/flutter#166349

Closed

Roll Packages from 125c117a432f to 28676de193f2 (26 revisions) flutter/flutter#166352

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

9e8b831

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll mentioned this pull request Apr 1, 2025

Roll Packages from 125c117a432f to eb8cb324582e (27 revisions) flutter/flutter#166356

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

33deac3

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

7a371f9

…ELOG entry (flutter/packages#8754)

This was referenced Apr 2, 2025

Roll Packages from 125c117a432f to 84ef201205ea (29 revisions) flutter/flutter#166435

Closed

Roll Packages from 125c117a432f to 5cee1525909d (30 revisions) flutter/flutter#166456

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

dc38a85

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll mentioned this pull request Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166457

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

5d4f9be

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

448d0d7

…ELOG entry (flutter/packages#8754)

This was referenced Apr 2, 2025

Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) flutter/flutter#166469

Closed

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166472

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

413d018

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2025

01f977156 [google_maps_flutter] Fix typo and remove duplicitous CHANG…

e7674f7

…ELOG entry (flutter/packages#8754)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Packages from 125c117a432f to 8f5844af8135 (32 revisions) flutter/flutter#166534

Closed

filiph deleted the fix/typo branch May 5, 2025 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry #8754

[google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry #8754

Uh oh!

filiph commented Feb 28, 2025 •

edited

Loading

Uh oh!

stuartmorgan-g commented Feb 28, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

filiph commented Mar 6, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Mar 6, 2025

Uh oh!

filiph Mar 6, 2025

Uh oh!

stuartmorgan-g Mar 6, 2025

Uh oh!

filiph Mar 6, 2025

Uh oh!

stuartmorgan-g commented Mar 25, 2025

Uh oh!

filiph commented Mar 26, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -1,3 +1,7 @@
		## 2.10.2

		* Fixes typos in README and CHANGELOG.

[google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry #8754

[google_maps_flutter] Fix typo and remove duplicitous CHANGELOG entry #8754

Uh oh!

Conversation

filiph commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented Feb 28, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

filiph commented Mar 6, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

filiph Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

filiph Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Mar 25, 2025

Uh oh!

filiph commented Mar 26, 2025

Uh oh!

Uh oh!

Uh oh!

filiph commented Feb 28, 2025 •

edited

Loading