Roll Flutter from 911aa7547ed7 to 0b96fa88fd83 (77 revisions) #8722
Conversation
…ace on 29. (#164109)" (flutter/flutter#164166)
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
…NavigationBar (flutter/flutter#162581)
…a to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209)
engine-flutter-autoroll
added
the
autosubmit
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @engine-flutter-autoroll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request is an automated roll of the Flutter engine from version 911aa7547ed7 to 0b96fa88fd83, encompassing 77 revisions. The primary change is updating the .ci/flutter_master.version file to reflect the new Flutter engine version. This type of PR is essential for keeping the Flutter engine up-to-date with the latest changes and improvements.
Highlights
- Engine Roll: The Flutter engine has been rolled from
911aa7547ed7to0b96fa88fd83, including 77 revisions. - Version Update: The
.ci/flutter_master.versionfile has been updated to point to the new Flutter engine version.
Changelog
- .ci/flutter_master.version
- Updated the Flutter engine version from
911aa7547ed7to0b96fa88fd83.
- Updated the Flutter engine version from
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the name of the Flutter's rendering engine?
Click here for the answer
The name of the Flutter's rendering engine is Impeller.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the Flutter engine version. Since this is an automated roll, the primary concern is ensuring the roll was successful and didn't introduce regressions. Monitoring the CI/CD pipelines and performance dashboards is crucial.
Summary of Findings
Assessment
This pull request rolls the Flutter engine to a new version. The change itself is straightforward, updating the version hash in .ci/flutter_master.version. Given the nature of this change (an automated roll), a detailed code review isn't applicable in the traditional sense. However, it's crucial to ensure that the roll was successful and didn't introduce any regressions. I recommend verifying the roll's impact on the overall Flutter project by checking the CI/CD pipelines and any relevant performance dashboards. Users should have others review and approve this code before merging.
|
autosubmit label was removed for flutter/packages/8722, because - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
|
Commit queue failed; closing this roll. |
engine-flutter-autoroll
deleted the
flutter-packages-536f34d8-f65f-4e4c-8ef0-3f727c1f70b3-1740596064
branch
Roll Flutter from 911aa75 to 0b96fa8 (77 revisions)
flutter/flutter@911aa75...0b96fa8
2025-02-26 jonahwilliams@google.com [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209)
2025-02-26 48155875+Michae1Weiss@users.noreply.github.com Add localization for
BackandCancelbuttons in CupertinoNavigationBar (flutter/flutter#162581)2025-02-26 30870216+gaaclarke@users.noreply.github.com Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038)
2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188)
2025-02-26 jason-simmons@users.noreply.github.com Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890)
2025-02-26 engine-flutter-autoroll@skia.org Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174)
2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168)
2025-02-26 dkwingsmt@users.noreply.github.com [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163)
2025-02-26 jonahwilliams@google.com [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126)
2025-02-26 jonahwilliams@google.com [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110)
2025-02-26 15619084+vashworth@users.noreply.github.com Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166)
2025-02-26 zanderso@users.noreply.github.com Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665)
2025-02-26 jonahwilliams@google.com [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109)
2025-02-26 chris@bracken.jp [iOS] Add platform view to integration_test example (flutter/flutter#164144)
2025-02-26 dominik@honnef.co Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942)
2025-02-26 louisehsu@google.com Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593)
2025-02-26 cloud@pathconnected.net Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955)
2025-02-26 engine-flutter-autoroll@skia.org Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973)
2025-02-26 flar@google.com [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054)
2025-02-25 polinach@google.com Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070)
2025-02-25 magder@google.com Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882)
2025-02-25 magder@google.com Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895)
2025-02-25 magder@google.com Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898)
2025-02-25 reidbaker@google.com Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies (flutter/flutter#164029)
2025-02-25 engine-flutter-autoroll@skia.org Roll Packages from 5498d4d to c44c228 (2 revisions) (flutter/flutter#164121)
2025-02-25 jason-simmons@users.noreply.github.com Increase the timeout for Mac web_tool_tests to 45 minutes (flutter/flutter#164118)
2025-02-25 reidbaker@google.com pure_android_host_apps/android_host_app_v2_embedding multiple gradle and AGP versions (flutter/flutter#163849)
2025-02-25 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] enable assets_unittests (flutter/flutter#164019)
2025-02-25 matej.knopp@gmail.com [Embedder] Wire view focus event and focus request (flutter/flutter#163930)
2025-02-25 engine-flutter-autoroll@skia.org Roll Skia from 521c27acf504 to 3ce6f25dc13e (1 revision) (flutter/flutter#164105)
2025-02-25 codefu@google.com Enable luci_flags for faster builds (flutter/flutter#164069)
2025-02-25 jonahwilliams@google.com [iOS] increase backdrop cached task limit. (flutter/flutter#164036)
2025-02-25 matanlurey@users.noreply.github.com Fix and test an edge case in
findPackageConfigFile. (flutter/flutter#163902)2025-02-25 matej.knopp@gmail.com [Windows] Use enum to configure UI thread policy (flutter/flutter#163727)
2025-02-25 engine-flutter-autoroll@skia.org Roll Skia from a141a3ceef87 to 521c27acf504 (8 revisions) (flutter/flutter#164083)
2025-02-25 tessertaha@gmail.com Fix
RangeSliderrenders track when track colors are transparent (flutter/flutter#162386)2025-02-25 walid.al.ashik@gmail.com Add BorderRadiusGeometry to Divider Widget for Customisable Border Radius (flutter/flutter#163414)
2025-02-25 ybz975218925@gmail.com SliverMainAxisGroup multiple PinnedHeaderSliver children (flutter/flutter#163528)
2025-02-25 matanlurey@users.noreply.github.com Move
AndroidRenderingApifromcommontoshell/platform/android(flutter/flutter#163796)2025-02-24 engine-flutter-autoroll@skia.org Roll Skia from 994168b1ba10 to a141a3ceef87 (1 revision) (flutter/flutter#164023)
2025-02-24 polinach@google.com Shorten method signature to make invokations fit one line. (flutter/flutter#163822)
2025-02-24 jason-simmons@users.noreply.github.com Roll .ci.yaml changes into the LUCI configuration only when the master branch is updated (flutter/flutter#163897)
2025-02-24 ueman@users.noreply.github.com Reland "Make Flutter version information accessible at runtime (#140783)" (flutter/flutter#163761)
2025-02-24 devoncarew@google.com [deps] update dep references from older repos to newer (current SOT) repos (flutter/flutter#163891)
...