[camera] Remove OCMock from FLTCamPhotoCaptureTests, FLTSavePhotoDelegateTests and StreamingTests #8590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchudy
requested review from
stuartmorgan-g
and removed request for
hellohuanlin
stuartmorgan-g
approved these changes
Feb 8, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
One naming comment, but otherwise LGTM!
It's great to see less code with comments warning about OCMock landmines.
...camera_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTFileWriting.h
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Feb 10, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM
Sorry, I should have clarified before: if I LGTM with minor comments and approve the PR, that means I don't think the changes need review, so you are welcome to just land it after making the changes (unless there's something that you feel needs further discussion, like if something I suggested is actually not correct).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 10, 2025
…ePhotoDelegateTests and StreamingTests (flutter/packages#8590)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 17, 2025
…ePhotoDelegateTests and StreamingTests (flutter/packages#8590)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 17, 2025
flutter/packages@625023a...8542af3 2025-02-15 stuartmorgan@google.com [various] Enable `permissive-` for Windows plugin examples (flutter/packages#8636) 2025-02-15 stuartmorgan@google.com [pigeon] Update task queue handling (flutter/packages#8627) 2025-02-14 goderbauer@google.com Update CODEOWNERS (flutter/packages#8628) 2025-02-14 32538273+ValentinVignal@users.noreply.github.com [flutter_adaptive_scaffold] Fix some memory leaks (flutter/packages#8546) 2025-02-14 mchudy@users.noreply.github.com [camera] Fix crash when setting activeFormat on FLTCaptureDevice (flutter/packages#8630) 2025-02-13 mchudy@users.noreply.github.com [camera] Remove remaining OCMock usage in tests (flutter/packages#8624) 2025-02-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Change callback methods with a non-null return type to non-null (flutter/packages#8564) 2025-02-12 737941+loic-sharma@users.noreply.github.com [google_sign_in_ios] Adds Swift Package Manager support (flutter/packages#7356) 2025-02-12 pawel.jakubowski@leancode.pl [camera_avfoundation] Migrate tests to Swift - part 1 (flutter/packages#8603) 2025-02-12 43054281+camsim99@users.noreply.github.com [video_player] Re-enables `asset videos live stream duration != 0` test for Android (flutter/packages#8610) 2025-02-12 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Add support for `TypedStatefulShellBranch`'s `preload` (flutter/packages#8587) 2025-02-12 magder@google.com [local_auth_darwin] Fix test name for clarity (flutter/packages#8499) 2025-02-11 ditman@gmail.com [ci] Manually roll master, set -Xmx4G (flutter/packages#8586) 2025-02-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 4 directories with 1 update (flutter/packages#8551) 2025-02-10 10687576+bparrishMines@users.noreply.github.com [pigeon] Add errors for ProxyAPI callback methods and null instances when reading in a ProxyApiBaseCodec (flutter/packages#8567) 2025-02-10 98884136+berhili098@users.noreply.github.com [shared_preferences]Fix : SetState returning future (flutter/packages#8398) 2025-02-10 stuartmorgan@google.com [various] Add deprecation notices to READMEs (flutter/packages#8598) 2025-02-10 mchudy@users.noreply.github.com [camera] Remove OCMock from CameraSettingsTests, CameraMethodChannelTests and CameraSessionPresetsTests (flutter/packages#8592) 2025-02-10 mchudy@users.noreply.github.com [camera] Remove OCMock from FLTCamPhotoCaptureTests, FLTSavePhotoDelegateTests and StreamingTests (flutter/packages#8590) 2025-02-07 32538273+ValentinVignal@users.noreply.github.com [go_router] Add `preload` parameter to `StatefulShellBranchData.$branch` (flutter/packages#8545) 2025-02-07 pawel.jakubowski@leancode.pl [video_player_avfoundation] iOS platform view support (flutter/packages#8237) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…gateTests and StreamingTests (flutter#8590) Continuation of OCMock removal from tests related to flutter/flutter#119109. Introduces two new protocols `FLTFileWriter` and `FLTCapturePhotoOutput`.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…gateTests and StreamingTests (flutter#8590) Continuation of OCMock removal from tests related to flutter/flutter#119109. Introduces two new protocols `FLTFileWriter` and `FLTCapturePhotoOutput`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of OCMock removal from tests related to flutter/flutter#119109. Introduces two new protocols
FLTFileWriterandFLTCapturePhotoOutput.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.