Skip to content

Re-land [shared_preferences] Add shared preferences devtool #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Re-land [shared_preferences] Add shared preferences devtool #8519

merged 1 commit into from
Jan 28, 2025

Conversation

stuartmorgan-g
Copy link
Contributor

Re-lands #8494 without changes, now that the unrelated failure is resolved. See #8515 for context.

tarrinneal
tarrinneal approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I said last time was the last time, but I'll make an exception one last time.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025
@auto-submit auto-submit bot merged commit 006504c into main Jan 28, 2025
78 checks passed
@auto-submit auto-submit bot deleted the revert-8515-revert-8494-add-shared-preferences-devtool branch January 28, 2025 19:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2025
@engine-flutter-autoroll
006504c28 Re-land [shared_preferences] Add shared preferences devtool (…
193daff 
…flutter/packages#8519)
@adsonpleal
Copy link
Contributor

@stuartmorgan, @kenzieschmoll, and @tarrinneal maybe not this time again 😬 .

Now we have a new issue.

There are files in the package directory that haven't been saved in git. Refusing to publish these files:

!! packages/shared_preferences/shared_preferences/.dart_tool/
!! packages/shared_preferences/shared_preferences/example/.dart_tool/
!! packages/shared_preferences/shared_preferences/example/.flutter-plugins
!! packages/shared_preferences/shared_preferences/example/.flutter-plugins-dependencies
!! packages/shared_preferences/shared_preferences/example/android/app/src/main/java/
!! packages/shared_preferences/shared_preferences/example/android/local.properties
!! packages/shared_preferences/shared_preferences/example/ios/Flutter/Generated.xcconfig
!! packages/shared_preferences/shared_preferences/example/ios/Flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/ios/Flutter/flutter_export_environment.sh
!! packages/shared_preferences/shared_preferences/example/ios/Runner/GeneratedPluginRegistrant.h
!! packages/shared_preferences/shared_preferences/example/ios/Runner/GeneratedPluginRegistrant.m
!! packages/shared_preferences/shared_preferences/example/linux/flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/linux/flutter/generated_plugin_registrant.cc
!! packages/shared_preferences/shared_preferences/example/linux/flutter/generated_plugin_registrant.h
!! packages/shared_preferences/shared_preferences/example/macos/Flutter/GeneratedPluginRegistrant.swift
!! packages/shared_preferences/shared_preferences/example/macos/Flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/pubspec.lock
!! packages/shared_preferences/shared_preferences/example/windows/flutter/ephemeral/
!! packages/shared_preferences/shared_preferences/example/windows/flutter/generated_plugin_registrant.cc
!! packages/shared_preferences/shared_preferences/example/windows/flutter/generated_plugin_registrant.h
!! packages/shared_preferences/shared_preferences/extension/devtools/build/
!! packages/shared_preferences/shared_preferences/pubspec.lock

I guess this is happening because !! packages/shared_preferences/shared_preferences/extension/devtools/build/ is generated before the publish, which is the intended behavior.

The error is being thrown here. And failing because of this.

At first I thought this shouldn't happen, since we have this ignore. But git status is being run with a --ignored flag.

My guess is that we need to have a way to tell _checkGitStatus that it should ignore certain paths.

stuartmorgan-g pushed a commit that referenced this pull request Jan 29, 2025
@stuartmorgan
Revert "Re-land [shared_preferences] Add shared preferences devtool (#…
cd399bd 
…8519)"

This reverts commit 006504c.
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jan 29, 2025
Merged
@stuartmorgan-g
Copy link
Contributor Author

I've opened a revert, and am working on a fix to the tooling.

@stuartmorgan-g
Copy link
Contributor Author

At first I thought this shouldn't happen, since we have this ignore. But git status is being run with a --ignored flag.

My guess is that we need to have a way to tell _checkGitStatus that it should ignore certain paths.

The fix is to just drop that flag. I believe it dates back to when pub publish didn't use .gitignore, so having extra files locally would pollute the published package.

stuartmorgan-g added a commit that referenced this pull request Jan 29, 2025
@stuartmorgan-g
Revert "Re-land [shared_preferences] Add shared preferences devtool" (#…
23f7c74 
…8529)

Reverts #8519 due to release failures. See
#8519 (comment)
@stuartmorgan-g
Copy link
Contributor Author

The re-re-re-land successfully released! 🎉

@tarrinneal
Copy link
Contributor

@adsonpleal https://www.youtube.com/watch?v=QUAItQmq-LU

@adsonpleal
Copy link
Contributor

🚀 the best part is the commit name revert-8529-revert-8519-revert-8515-revert-8494-add-shared-preferences-devtool 😂

@adsonpleal
Copy link
Contributor

FYK, I've just published a discontinuation notice for the standalone package.

@stuartmorgan-g
Copy link
Contributor Author

🚀 the best part is the commit name revert-8529-revert-8519-revert-8515-revert-8494-add-shared-preferences-devtool 😂

It's definitely not not not not not a bad name!

@stuartmorgan-g
Copy link
Contributor Author

More seriously, thanks for bearing with all the churn here. The auto-release mechanics are unfortunately one of the areas with the least pre-submit validation.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
006504c28 Re-land [shared_preferences] Add shared preferences devtool (…
2d180d3 
…flutter/packages#8519)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
006504c28 Re-land [shared_preferences] Add shared preferences devtool (…
ac397ec 
…flutter/packages#8519)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
Roll Packages from 02c6fef4ef63 to e6ce02c2a859 (25 revisions) (#162760)
b6f659e 
flutter/packages@02c6fef...e6ce02c

2025-02-05 65381000+raju8000@users.noreply.github.com [vector_graphics]
Allow transition between placeholder and loaded image to have an
animation (flutter/packages#8195)
2025-02-04 andrechalella@gmail.com [flutter_markdown] Make custom table
column alignments work when text wraps (flutter/packages#8340)
2025-02-04 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds internal wrapper for iOS native
`IMAAdPodInfo` (flutter/packages#8429)
2025-02-03 tarrinneal@gmail.com [pigeon] reorg generator files
(flutter/packages#8532)
2025-02-03 byoungchan.lee@gmx.com [pigeon] [swift] Fix `PigeonError`
sendability conformance in Swift 6 (flutter/packages#8302)
2025-02-03 engine-flutter-autoroll@skia.org Roll Flutter from
b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556)
2025-02-03 20989940+aednlaxer@users.noreply.github.com
[google_maps_flutter] Support for Ground Overlay - platform interface
(flutter/packages#8518)
2025-01-31 737941+loic-sharma@users.noreply.github.com [tool] Add
--xcode-warnings-exceptions flag (flutter/packages#8524)
2025-01-31 stuartmorgan@google.com [tool] Ensure that injected
dependency overrides are sorted (flutter/packages#8542)
2025-01-31 jonahwilliams@google.com [vector_graphics] Revert leak
tracker change (flutter/packages#8544)
2025-01-31 parlough@gmail.com [shared_preferences_tool] Loosen
vm_service constraint to allow for 15 (flutter/packages#8539)
2025-01-31 32538273+ValentinVignal@users.noreply.github.com
[in_app_purchase] Activate leak testing for android
(flutter/packages#8369)
2025-01-31 cunderw@gmail.com [flutter_markdown] Allow tables to be
scrollable with IntrinsicColumnWidth (flutter/packages#8526)
2025-01-30 goderbauer@google.com Update CODEOWNERS for pkg:animations
(flutter/packages#8534)
2025-01-30 engine-flutter-autoroll@skia.org Roll Flutter from
c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527)
2025-01-30 pawel.jakubowski@leancode.pl [video_player_web] Adjust Web
implementation to the new platform interface (flutter/packages#8528)
2025-01-30 tarrinneal@gmail.com [shared_preferences] Exposed
SharedPreferencesOptions. (flutter/packages#8530)
2025-01-29 stuartmorgan@google.com Re-land [shared_preferences] Add
shared preferences devtool (flutter/packages#8531)
2025-01-29 84978733+alejandro-all-win-software@users.noreply.github.com
[in_app_purchase_storekit] Add Swift Package Manager compatibility
(flutter/packages#8469)
2025-01-29 stuartmorgan@google.com Revert "Re-land [shared_preferences]
Add shared preferences devtool" (flutter/packages#8529)
2025-01-29 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Fixes trailing `?` by comparing iterables
(flutter/packages#8521)
2025-01-29 737941+loic-sharma@users.noreply.github.com [tool] Refactor
args of strings or YAML file lists (flutter/packages#8513)
2025-01-28 48155875+Michae1Weiss@users.noreply.github.com [go_router]
Add missing await keyword to onTap callback in the code example in
`navigation.md` (flutter/packages#8343)
2025-01-28 stuartmorgan@google.com Re-land [shared_preferences] Add
shared preferences devtool (flutter/packages#8519)
2025-01-28 32538273+ValentinVignal@users.noreply.github.com
[vector_graphics] Fix memory leaks and activate leak testing
[prod-leak-fix] (flutter/packages#8373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@stuartmorgan-g @androidseb
Re-land [shared_preferences] Add shared preferences devtool (flutter#…
6976dfa 
…8519)

Re-lands flutter#8494 without changes, now that the unrelated failure is resolved. See flutter#8515 for context.
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@stuartmorgan-g @androidseb
Revert "Re-land [shared_preferences] Add shared preferences devtool" (f…
7870b94 
…lutter#8529)

Reverts flutter#8519 due to release failures. See
flutter#8519 (comment)
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@stuartmorgan-g @FMorschel
Re-land [shared_preferences] Add shared preferences devtool (flutter#…
0ecb158 
…8519)

Re-lands flutter#8494 without changes, now that the unrelated failure is resolved. See flutter#8515 for context.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@stuartmorgan-g @FMorschel
Revert "Re-land [shared_preferences] Add shared preferences devtool" (f…
e72507d 
…lutter#8529)

Reverts flutter#8519 due to release failures. See
flutter#8519 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@kenzieschmoll kenzieschmoll Awaiting requested review from kenzieschmoll

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: shared_preferences platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartmorgan-g @adsonpleal @tarrinneal @stuartmorgan