-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[shared_preferences] Add shared preferences devtool #8494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kenzieschmoll
merged 5 commits into
flutter:main
from
adsonpleal:add-shared-preferences-devtool
Jan 24, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
173819f
Add shared preferences dev tool
adsonpleal a134052
update release workflow to latest flutter version
adsonpleal 7a77417
Merge branch 'main' into add-shared-preferences-devtool
adsonpleal a8b594c
Merge remote-tracking branch 'origin/main' into add-shared-preference…
adsonpleal 4d72c4a
Merge branch 'add-shared-preferences-devtool' of github.com:adsonplea…
adsonpleal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/shared_preferences/shared_preferences/extension/devtools/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| build |
1 change: 1 addition & 0 deletions
1
packages/shared_preferences/shared_preferences/extension/devtools/.pubignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| !build |
4 changes: 4 additions & 0 deletions
4
packages/shared_preferences/shared_preferences/extension/devtools/config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| name: shared_preferences | ||
| issueTracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+shared_preferences%22 | ||
| version: 1.0.0 | ||
| materialIconCodePoint: '0xe683' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
...ed_preferences/shared_preferences/lib/src/shared_preferences_devtools_extension_data.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:convert'; | ||
| import 'dart:developer' as developer; | ||
|
|
||
| import 'package:flutter/foundation.dart'; | ||
|
|
||
| import '../shared_preferences.dart'; | ||
|
|
||
| const String _eventPrefix = 'shared_preferences.'; | ||
|
|
||
| /// A typedef for the post event function. | ||
| @visibleForTesting | ||
| typedef PostEvent = void Function( | ||
| String eventKind, | ||
| Map<String, Object?> eventData, | ||
| ); | ||
|
|
||
| /// A helper class that provides data to the DevTools extension. | ||
| /// | ||
| /// It is only visible for testing and eval. | ||
| @visibleForTesting | ||
| class SharedPreferencesDevToolsExtensionData { | ||
| /// The default constructor for [SharedPreferencesDevToolsExtensionData]. | ||
| /// | ||
| /// Accepts an optional [PostEvent] that should only be overwritten when testing. | ||
| const SharedPreferencesDevToolsExtensionData([ | ||
| this._postEvent = developer.postEvent, | ||
| ]); | ||
|
|
||
| final PostEvent _postEvent; | ||
|
|
||
| /// Requests all legacy and async keys and post an event with the result. | ||
| Future<void> requestAllKeys() async { | ||
| final SharedPreferences legacyPrefs = await SharedPreferences.getInstance(); | ||
| final Set<String> legacyKeys = legacyPrefs.getKeys(); | ||
| final Set<String> asyncKeys = await SharedPreferencesAsync().getKeys(); | ||
|
|
||
| _postEvent('${_eventPrefix}all_keys', <String, List<String>>{ | ||
| 'asyncKeys': asyncKeys.toList(), | ||
| 'legacyKeys': legacyKeys.toList(), | ||
| }); | ||
| } | ||
|
|
||
| /// Requests the value for a given key and posts an event with the result. | ||
| Future<void> requestValue(String key, bool legacy) async { | ||
| final Object? value; | ||
| if (legacy) { | ||
| final SharedPreferences legacyPrefs = | ||
| await SharedPreferences.getInstance(); | ||
| value = legacyPrefs.get(key); | ||
| } else { | ||
| value = await SharedPreferencesAsync().getAll(allowList: <String>{ | ||
| key | ||
| }).then((Map<String, Object?> map) => map.values.firstOrNull); | ||
| } | ||
|
|
||
| _postEvent('${_eventPrefix}value', <String, Object?>{ | ||
| 'value': value, | ||
| // It is safe to use `runtimeType` here. This code | ||
| // will only ever run in debug mode. | ||
| 'kind': value.runtimeType.toString(), | ||
| }); | ||
| } | ||
|
|
||
| /// Requests the value change for the given key and posts an empty event when finished. | ||
| Future<void> requestValueChange( | ||
| String key, | ||
| String serializedValue, | ||
| String kind, | ||
| bool legacy, | ||
| ) async { | ||
| final Object? value = jsonDecode(serializedValue); | ||
| if (legacy) { | ||
| final SharedPreferences legacyPrefs = | ||
| await SharedPreferences.getInstance(); | ||
| // we need to check the kind because sometimes a double | ||
| // gets interpreted as an int. If this was not an issue | ||
| // we'd only need to do a simple pattern matching on value. | ||
| switch (kind) { | ||
| case 'int': | ||
| await legacyPrefs.setInt(key, value! as int); | ||
| case 'bool': | ||
| await legacyPrefs.setBool(key, value! as bool); | ||
| case 'double': | ||
| await legacyPrefs.setDouble(key, value! as double); | ||
| case 'String': | ||
| await legacyPrefs.setString(key, value! as String); | ||
| case 'List<String>': | ||
| await legacyPrefs.setStringList( | ||
| key, | ||
| (value! as List<Object?>).cast(), | ||
| ); | ||
| } | ||
| } else { | ||
| final SharedPreferencesAsync prefs = SharedPreferencesAsync(); | ||
| // we need to check the kind because sometimes a double | ||
| // gets interpreted as an int. If this was not an issue | ||
| // we'd only need to do a simple pattern matching on value. | ||
| switch (kind) { | ||
| case 'int': | ||
| await prefs.setInt(key, value! as int); | ||
| case 'bool': | ||
| await prefs.setBool(key, value! as bool); | ||
| case 'double': | ||
| await prefs.setDouble(key, value! as double); | ||
| case 'String': | ||
| await prefs.setString(key, value! as String); | ||
| case 'List<String>': | ||
| await prefs.setStringList( | ||
| key, | ||
| (value! as List<Object?>).cast(), | ||
| ); | ||
| } | ||
| } | ||
| _postEvent('${_eventPrefix}change_value', <String, Object?>{}); | ||
| } | ||
|
|
||
| /// Requests a key removal and posts an empty event when removed. | ||
| Future<void> requestRemoveKey(String key, bool legacy) async { | ||
| if (legacy) { | ||
| final SharedPreferences legacyPrefs = | ||
| await SharedPreferences.getInstance(); | ||
| await legacyPrefs.remove(key); | ||
| } else { | ||
| await SharedPreferencesAsync().remove(key); | ||
| } | ||
| _postEvent('${_eventPrefix}remove', <String, Object?>{}); | ||
| } | ||
| } | ||
|
|
||
| /// Include a variable to keep the library alive in web builds. | ||
| /// It must be a `final` variable. | ||
| /// Check this discussion for more info: https://github.com/flutter/packages/pull/6749/files/6eb1b4fdce1eba107294770d581713658ff971e9#discussion_r1755375409 | ||
| // ignore: prefer_const_declarations | ||
| final bool fieldToKeepDevtoolsExtensionLibraryAlive = false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenzieschmoll and @tarrinneal this is the only change from the previous PR.