[webview_flutter] Adds support to control overscrolling #8451

bparrishMines · 2025-01-17T03:04:17Z

All federated changes for
flutter/flutter#57090

Fixes flutter/flutter#57090

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…croll

Piinks · 2025-04-02T22:15:45Z

Greetings from stale PR triage. 😁
@bparrishMines is this still on your radar?

bparrishMines · 2025-04-07T21:32:05Z

@Piinks Yes, I will work on updating it this week. It loss some priority caused by the ProxyApi update to iOS.

…croll

stuartmorgan-g

LGTM with nits; this is ready to split apart.

packages/webview_flutter/webview_flutter/lib/src/webview_controller.dart

stuartmorgan-g · 2025-04-10T20:01:06Z

packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/over_scroll_mode.dart

+  always,
+
+  /// Allow a user to over-scroll the WebView only if the content is large
+  /// enough to meaningfully scroll.


What does "meaningfully" mean here? Isn't the behavior of this mode just that it will allow overscroll any time the content is larger than the viewport?

That is how I interpreted it as well. This language is similar to how Android describes it: https://developer.android.com/reference/android/view/View#OVER_SCROLL_IF_CONTENT_SCROLLS.

If it seems clearer to make this more technical by using "content is larger than the viewport" then I'm fine with switching it. I assumed most developers would interpret "meaningfully" the same way as we did.

I would prefer we be explicit; I was confused by the current language (and the Android language) because I'm not sure what "meaningfully" is supposed to indicate here. I.e., what is the case where the content can scroll but not "meaningfully scroll"? I guess it means overscrolling?

I think the "meaningfully scroll" only refers to the size of the content relative to the viewport. I think overscroll typically adds to the page to make it seem scrollable.

I changed the documentation in the platform interface PR.

…croll

bparrishMines · 2025-04-17T19:32:06Z

packages/webview_flutter/webview_flutter/pubspec.yaml

-  sdk: ^3.5.0
-  flutter: ">=3.24.0"
+  sdk: ^3.6.0
+  flutter: ">=3.27.0"


This is the minimum version for webview_flutter_android.

stuartmorgan-g

LGTM

…utter/packages#8451)

flutter/packages@2fcc403...ac21f53 2025-04-20 engine-flutter-autoroll@skia.org Roll Flutter from 3ed38e2 to cfb887c (17 revisions) (flutter/packages#9118) 2025-04-19 stuartmorgan@google.com [various] Scrubs pre-SDK-21 Android code (flutter/packages#9112) 2025-04-18 engine-flutter-autoroll@skia.org Roll Flutter from ecabb1a to 3ed38e2 (23 revisions) (flutter/packages#9114) 2025-04-18 ricardodalarme@outlook.com [flutter_svg] feat: Expose the `colorMapper` property in `SvgPicture` (flutter/packages#9043) 2025-04-18 stuartmorgan@google.com [tool] Add initial file-based command skipping (flutter/packages#8928) 2025-04-18 stuartmorgan@google.com [pigeon] Convert test plugins to SPM (flutter/packages#9105) 2025-04-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to control overscrolling (flutter/packages#8451) 2025-04-17 louisehsu@google.com [in_app_purchase] add Storefront.countryCode() and AppStore.sync() (flutter/packages#8900) 2025-04-17 145144088+camfrandsen@users.noreply.github.com [webview_flutter_wkwebview] Expose the allowsLinkPreview property in WKWebView for iOS (flutter/packages#5029) 2025-04-17 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations to set over-scroll mode (flutter/packages#9101) 2025-04-17 1063596+reidbaker@users.noreply.github.com [shared_preferences] Update AGP to 8.9.1 (flutter/packages#9106) 2025-04-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds Kotlin lint tests to example code and fix lints (flutter/packages#9034) 2025-04-17 30872003+misos1@users.noreply.github.com [video_player_avfoundation] enable more than 30 fps (flutter/packages#7466) 2025-04-17 engine-flutter-autoroll@skia.org Roll Flutter from aef4718 to ecabb1a (25 revisions) (flutter/packages#9104) 2025-04-16 stuartmorgan@google.com [pigeon] Unify iOS and macOS test plugins (flutter/packages#9100) 2025-04-16 engine-flutter-autoroll@skia.org Roll Flutter from db68c95 to aef4718 (7 revisions) (flutter/packages#9098) 2025-04-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds method to set overscroll mode (flutter/packages#9099) 2025-04-16 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/packages#8984) 2025-04-16 stuartmorgan@google.com [google_sign_is] Update iOS SDK to 8.0 (flutter/packages#9081) 2025-04-16 robert.odrowaz@leancode.pl [camera_avfoundation] Implementation swift migration (flutter/packages#8988) 2025-04-16 32538273+ValentinVignal@users.noreply.github.com [go_router] Adds `caseSensitive` to `GoRoute` (flutter/packages#8992) 2025-04-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) (flutter/packages#9092) 2025-04-15 stuartmorgan@google.com [tool] Run config-only build for iOS/macOS native-test (flutter/packages#9080) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/packages@2fcc403...ac21f53 2025-04-20 engine-flutter-autoroll@skia.org Roll Flutter from 409a8ac to cd51fa3 (17 revisions) (flutter/packages#9118) 2025-04-19 stuartmorgan@google.com [various] Scrubs pre-SDK-21 Android code (flutter/packages#9112) 2025-04-18 engine-flutter-autoroll@skia.org Roll Flutter from d0741df to 409a8ac (23 revisions) (flutter/packages#9114) 2025-04-18 ricardodalarme@outlook.com [flutter_svg] feat: Expose the `colorMapper` property in `SvgPicture` (flutter/packages#9043) 2025-04-18 stuartmorgan@google.com [tool] Add initial file-based command skipping (flutter/packages#8928) 2025-04-18 stuartmorgan@google.com [pigeon] Convert test plugins to SPM (flutter/packages#9105) 2025-04-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to control overscrolling (flutter/packages#8451) 2025-04-17 louisehsu@google.com [in_app_purchase] add Storefront.countryCode() and AppStore.sync() (flutter/packages#8900) 2025-04-17 145144088+camfrandsen@users.noreply.github.com [webview_flutter_wkwebview] Expose the allowsLinkPreview property in WKWebView for iOS (flutter/packages#5029) 2025-04-17 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations to set over-scroll mode (flutter/packages#9101) 2025-04-17 1063596+reidbaker@users.noreply.github.com [shared_preferences] Update AGP to 8.9.1 (flutter/packages#9106) 2025-04-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds Kotlin lint tests to example code and fix lints (flutter/packages#9034) 2025-04-17 30872003+misos1@users.noreply.github.com [video_player_avfoundation] enable more than 30 fps (flutter/packages#7466) 2025-04-17 engine-flutter-autoroll@skia.org Roll Flutter from 9616f9c to d0741df (25 revisions) (flutter/packages#9104) 2025-04-16 stuartmorgan@google.com [pigeon] Unify iOS and macOS test plugins (flutter/packages#9100) 2025-04-16 engine-flutter-autoroll@skia.org Roll Flutter from a7ce7ff to 9616f9c (7 revisions) (flutter/packages#9098) 2025-04-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds method to set overscroll mode (flutter/packages#9099) 2025-04-16 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/packages#8984) 2025-04-16 stuartmorgan@google.com [google_sign_is] Update iOS SDK to 8.0 (flutter/packages#9081) 2025-04-16 robert.odrowaz@leancode.pl [camera_avfoundation] Implementation swift migration (flutter/packages#8988) 2025-04-16 32538273+ValentinVignal@users.noreply.github.com [go_router] Adds `caseSensitive` to `GoRoute` (flutter/packages#8992) 2025-04-16 engine-flutter-autoroll@skia.org Manual roll Flutter from f2d54fd to a7ce7ff (98 revisions) (flutter/packages#9092) 2025-04-15 stuartmorgan@google.com [tool] Run config-only build for iOS/macOS native-test (flutter/packages#9080) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

All federated changes for flutter/flutter#57090 Fixes flutter/flutter#57090

bparrishMines added 2 commits January 9, 2025 15:17

add scrollmode

34ddd2f

Merge branch 'main' of github.com:flutter/packages into android_overs…

1d3902a

…croll

github-actions bot added platform-android p: webview_flutter labels Jan 17, 2025

bparrishMines added 2 commits January 31, 2025 15:49

Merge branch 'main' of github.com:flutter/packages into android_overs…

5bb0696

…croll

add platform updates

4d3d081

github-actions bot added platform-ios platform-web labels Jan 31, 2025

fix docs

01da228

Merge branch 'main' of github.com:flutter/packages into android_overs…

4e50d1b

…croll

bparrishMines added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Apr 7, 2025

bparrishMines changed the title ~~Android overscroll~~ [webview_flutter] Adds support to control overscrolling Apr 7, 2025

bparrishMines added 3 commits April 7, 2025 17:48

update mocks and add webview flutter test

acb1363

export overscroll mode

6ba6cf5

undo web

0f923bd

github-actions bot removed the platform-web label Apr 7, 2025

bparrishMines added 2 commits April 7, 2025 20:38

android impl test

d52fc36

ios tests

0d0df61

bparrishMines requested a review from stuartmorgan-g April 8, 2025 02:19

bparrishMines marked this pull request as ready for review April 8, 2025 02:19

bparrishMines requested a review from cbracken as a code owner April 8, 2025 02:19

stuartmorgan-g reviewed Apr 10, 2025

View reviewed changes

bparrishMines added 6 commits April 15, 2025 18:27

Merge branch 'main' of github.com:flutter/packages into android_overs…

63d7fdc

…croll

Merge branch 'main' of github.com:flutter/packages into android_overs…

78ef3c7

…croll

add destroy back in

b297998

add default behavior

fadbd3e

forgot value

5b45350

Merge branch 'main' of github.com:flutter/packages into android_overs…

1b18d6c

…croll

bparrishMines added 4 commits April 17, 2025 15:07

Merge branch 'main' of github.com:flutter/packages into android_overs…

f89d0ab

…croll

version bump

e90b60a

fix changelog

c036f7d

pubspec changes

ffc8dd4

github-actions bot removed platform-android platform-ios labels Apr 17, 2025

bparrishMines added 2 commits April 17, 2025 15:30

flutter version bump

6a09a85

Merge branch 'main' of github.com:flutter/packages into android_overs…

ea6d045

…croll

bparrishMines commented Apr 17, 2025

View reviewed changes

stuartmorgan-g approved these changes Apr 17, 2025

View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

auto-submit bot merged commit 6317cd6 into flutter:main Apr 18, 2025
82 checks passed

bparrishMines deleted the android_overscroll branch April 18, 2025 03:43

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2025

6317cd601 [webview_flutter] Adds support to control overscrolling (fl…

bf29c70

…utter/packages#8451)

engine-flutter-autoroll mentioned this pull request Apr 21, 2025

Roll Packages from 2fcc4032dd8b to ac21f531a0cc (23 revisions) flutter/flutter#167479

Merged

androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025

[webview_flutter] Adds support to control overscrolling (flutter#8451)

399d235

All federated changes for flutter/flutter#57090 Fixes flutter/flutter#57090

FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025

[webview_flutter] Adds support to control overscrolling (flutter#8451)

b8694c2

All federated changes for flutter/flutter#57090 Fixes flutter/flutter#57090

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[webview_flutter] Adds support to control overscrolling #8451

[webview_flutter] Adds support to control overscrolling #8451

Uh oh!

bparrishMines commented Jan 17, 2025 •

edited by stuartmorgan-g

Loading

Uh oh!

Piinks commented Apr 2, 2025

Uh oh!

bparrishMines commented Apr 7, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

stuartmorgan-g Apr 10, 2025

Uh oh!

bparrishMines Apr 16, 2025

Uh oh!

stuartmorgan-g Apr 16, 2025

Uh oh!

bparrishMines Apr 16, 2025 •

edited

Loading

Uh oh!

bparrishMines Apr 17, 2025

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

[webview_flutter] Adds support to control overscrolling #8451

[webview_flutter] Adds support to control overscrolling #8451

Uh oh!

Conversation

bparrishMines commented Jan 17, 2025 • edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Piinks commented Apr 2, 2025

Uh oh!

bparrishMines commented Apr 7, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

bparrishMines Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

bparrishMines Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bparrishMines Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bparrishMines commented Jan 17, 2025 •

edited by stuartmorgan-g

Loading

bparrishMines Apr 16, 2025 •

edited

Loading