[vector_graphics] Allow transition between placeholder and loaded image to have an animation #8195

raju-muliyashiya · 2024-11-27T17:50:45Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.
Issue #158857

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

…ge to have an animation #158857

…ition-enhancement

raju-muliyashiya · 2024-11-29T08:25:06Z

@stuartmorgan Can you review this?
Thanks.

stuartmorgan-g · 2024-12-13T16:15:12Z

@jonahwilliams Are these package's PRs being included in engine PR triage?

jonahwilliams · 2024-12-16T21:26:23Z

They were not

jonahwilliams · 2024-12-16T21:27:27Z

packages/vector_graphics/lib/src/vector_graphics.dart

@@ -61,6 +61,7 @@ VectorGraphic createCompatVectorGraphic({
  String? semanticsLabel,
  bool excludeFromSemantics = false,
  Clip clipBehavior = Clip.hardEdge,
+  Duration transitionDuration = const Duration(milliseconds: 500),


This doesn't just allow the transition, it forces it on for all apps. should this be opt in if a transition duration is specififed?

To clarify, by providing a default value here and having the value be non-nullable, you will make all vector graphics fade in over 0.5 seconds. You must change this to be nullable with a null default or I will not accept the change

raju-muliyashiya

Removed default duration

jonahwilliams

I still see the default duration.

jonahwilliams · 2025-01-18T21:48:16Z

packages/vector_graphics/lib/src/vector_graphics.dart

@@ -61,6 +61,7 @@ VectorGraphic createCompatVectorGraphic({
  String? semanticsLabel,
  bool excludeFromSemantics = false,
  Clip clipBehavior = Clip.hardEdge,
+  Duration transitionDuration = const Duration(milliseconds: 500),


To clarify, by providing a default value here and having the value be non-nullable, you will make all vector graphics fade in over 0.5 seconds. You must change this to be nullable with a null default or I will not accept the change

jonahwilliams · 2025-01-27T22:39:04Z

packages/vector_graphics/lib/src/vector_graphics.dart

-            width: widget.width,
-            height: widget.height,
-          );
+      child = widget.placeholderBuilder != null


Instead of the double nested ternary please right a helper function and/or some if statements.

…ition-enhancement # Conflicts: # packages/vector_graphics/CHANGELOG.md # packages/vector_graphics/pubspec.yaml

jonahwilliams

LGTM

…loaded image to have an animation (flutter/packages#8195)

flutter/packages@02c6fef...e6ce02c 2025-02-05 65381000+raju8000@users.noreply.github.com [vector_graphics] Allow transition between placeholder and loaded image to have an animation (flutter/packages#8195) 2025-02-04 andrechalella@gmail.com [flutter_markdown] Make custom table column alignments work when text wraps (flutter/packages#8340) 2025-02-04 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMAAdPodInfo` (flutter/packages#8429) 2025-02-03 tarrinneal@gmail.com [pigeon] reorg generator files (flutter/packages#8532) 2025-02-03 byoungchan.lee@gmx.com [pigeon] [swift] Fix `PigeonError` sendability conformance in Swift 6 (flutter/packages#8302) 2025-02-03 engine-flutter-autoroll@skia.org Roll Flutter from b007899 to 8e2a6fc (61 revisions) (flutter/packages#8556) 2025-02-03 20989940+aednlaxer@users.noreply.github.com [google_maps_flutter] Support for Ground Overlay - platform interface (flutter/packages#8518) 2025-01-31 737941+loic-sharma@users.noreply.github.com [tool] Add --xcode-warnings-exceptions flag (flutter/packages#8524) 2025-01-31 stuartmorgan@google.com [tool] Ensure that injected dependency overrides are sorted (flutter/packages#8542) 2025-01-31 jonahwilliams@google.com [vector_graphics] Revert leak tracker change (flutter/packages#8544) 2025-01-31 parlough@gmail.com [shared_preferences_tool] Loosen vm_service constraint to allow for 15 (flutter/packages#8539) 2025-01-31 32538273+ValentinVignal@users.noreply.github.com [in_app_purchase] Activate leak testing for android (flutter/packages#8369) 2025-01-31 cunderw@gmail.com [flutter_markdown] Allow tables to be scrollable with IntrinsicColumnWidth (flutter/packages#8526) 2025-01-30 goderbauer@google.com Update CODEOWNERS for pkg:animations (flutter/packages#8534) 2025-01-30 engine-flutter-autoroll@skia.org Roll Flutter from c1ffaa9 to b007899 (43 revisions) (flutter/packages#8527) 2025-01-30 pawel.jakubowski@leancode.pl [video_player_web] Adjust Web implementation to the new platform interface (flutter/packages#8528) 2025-01-30 tarrinneal@gmail.com [shared_preferences] Exposed SharedPreferencesOptions. (flutter/packages#8530) 2025-01-29 stuartmorgan@google.com Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8531) 2025-01-29 84978733+alejandro-all-win-software@users.noreply.github.com [in_app_purchase_storekit] Add Swift Package Manager compatibility (flutter/packages#8469) 2025-01-29 stuartmorgan@google.com Revert "Re-land [shared_preferences] Add shared preferences devtool" (flutter/packages#8529) 2025-01-29 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Fixes trailing `?` by comparing iterables (flutter/packages#8521) 2025-01-29 737941+loic-sharma@users.noreply.github.com [tool] Refactor args of strings or YAML file lists (flutter/packages#8513) 2025-01-28 48155875+Michae1Weiss@users.noreply.github.com [go_router] Add missing await keyword to onTap callback in the code example in `navigation.md` (flutter/packages#8343) 2025-01-28 stuartmorgan@google.com Re-land [shared_preferences] Add shared preferences devtool (flutter/packages#8519) 2025-01-28 32538273+ValentinVignal@users.noreply.github.com [vector_graphics] Fix memory leaks and activate leak testing [prod-leak-fix] (flutter/packages#8373) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ge to have an animation (flutter#8195) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* [Issue #158857](flutter/flutter#158857)

raju-muliyashiya added 4 commits November 27, 2024 23:04

[vector_graphics] Allow transition between placeholder and loaded ima…

91b9e6d

…ge to have an animation #158857

Merge remote-tracking branch 'origin/main' into vector-graphics-trans…

5fb0571

…ition-enhancement

[vector_graphics] version pump

d2c51f9

[vector_graphics] removed un-used asset

07a6931

raju-muliyashiya requested a review from jonahwilliams as a code owner November 27, 2024 17:50

github-actions bot added the p: vector_graphics label Nov 27, 2024

raju-muliyashiya and others added 3 commits November 27, 2024 23:35

[vector_graphics] change log added

ad64be4

[vector_graphics] re-format code

018b454

Merge branch 'main' into vector-graphics-transition-enhancement

a88f20f

Merge branch 'main' into vector-graphics-transition-enhancement

4b11672

jonahwilliams requested changes Dec 16, 2024

View reviewed changes

raju-muliyashiya and others added 2 commits December 22, 2024 17:19

Merge branch 'flutter:main' into vector-graphics-transition-enhancement

3912d29

[vector_graphics] removed default Duration for animation

56beb50

raju-muliyashiya commented Dec 22, 2024

View reviewed changes

jonahwilliams requested changes Jan 6, 2025

View reviewed changes

raju-muliyashiya and others added 2 commits January 17, 2025 21:57

Merge branch 'flutter:main' into vector-graphics-transition-enhancement

60b3300

[vector_graphics] removed default Duration for animation

67cb047

jonahwilliams requested changes Jan 18, 2025

View reviewed changes

[vector_graphics] removed default Duration for animation

65c0768

jonahwilliams reviewed Jan 27, 2025

View reviewed changes

raju-muliyashiya added 2 commits February 2, 2025 17:15

Merge remote-tracking branch 'origin/main' into vector-graphics-trans…

5489268

…ition-enhancement # Conflicts: # packages/vector_graphics/CHANGELOG.md # packages/vector_graphics/pubspec.yaml

[vector_graphics] removed default Duration for animation

7bfb80f

jonahwilliams approved these changes Feb 5, 2025

View reviewed changes

jonahwilliams requested a review from domesticmouse February 5, 2025 01:03

domesticmouse approved these changes Feb 5, 2025

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025

auto-submit bot merged commit e6ce02c into flutter:main Feb 5, 2025
77 checks passed

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Packages from 02c6fef4ef63 to e6ce02c2a859 (25 revisions) flutter/flutter#162744

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025

e6ce02c2a [vector_graphics] Allow transition between placeholder and …

29974b5

…loaded image to have an animation (flutter/packages#8195)

engine-flutter-autoroll mentioned this pull request Feb 5, 2025

Roll Packages from 02c6fef4ef63 to e6ce02c2a859 (25 revisions) flutter/flutter#162760

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 5, 2025

e6ce02c2a [vector_graphics] Allow transition between placeholder and …

1ab5c45

…loaded image to have an animation (flutter/packages#8195)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[vector_graphics] Allow transition between placeholder and loaded image to have an animation #8195

[vector_graphics] Allow transition between placeholder and loaded image to have an animation #8195

Uh oh!

raju-muliyashiya commented Nov 27, 2024 •

edited

Loading

Uh oh!

raju-muliyashiya commented Nov 29, 2024

Uh oh!

stuartmorgan-g commented Dec 13, 2024

Uh oh!

jonahwilliams commented Dec 16, 2024

Uh oh!

jonahwilliams Dec 16, 2024

Uh oh!

jonahwilliams Jan 18, 2025

Uh oh!

raju-muliyashiya left a comment

Uh oh!

jonahwilliams left a comment

Uh oh!

jonahwilliams Jan 18, 2025

Uh oh!

jonahwilliams Jan 27, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

Uh oh!

Uh oh!

[vector_graphics] Allow transition between placeholder and loaded image to have an animation #8195

[vector_graphics] Allow transition between placeholder and loaded image to have an animation #8195

Uh oh!

Conversation

raju-muliyashiya commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

raju-muliyashiya commented Nov 29, 2024

Uh oh!

stuartmorgan-g commented Dec 13, 2024

Uh oh!

jonahwilliams commented Dec 16, 2024

Uh oh!

jonahwilliams Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

raju-muliyashiya left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

raju-muliyashiya commented Nov 27, 2024 •

edited

Loading