-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[in_app_purchase_storekit] Add support for purchase and transactions #7574 #7812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… iap_add_purchase
Oops, I accidentally updated your comment when I meant to quote it. Even thought storekittest is technically a mac 11 framework, the bulk of the testing features, such simulating network errors and things like that are mac 14 only. The presubmits passed because it ran on a Mac 14 bot, but the post submit failed because it ran on a Mac 13 bot. :( I've removed the reference to the tests in the mac project in the mean time, since I'm not sure when we'll fully upgrade our fleet. The tests are shared between mac and ios, so the code coverage should be the same. |
This failed
|
…actions #7574" (#7886) Reverts #7812 See #7812 (comment)
I think that if in your next version of this you temporarily, in your PR, change the |
Oh, thats a good idea. Im really struggling with testing this properly cuz I have to keep restarting and trying to get specific bots. |
flutter/packages@a35f02d...5582669 2024-10-17 50643541+Mairramer@users.noreply.github.com [two_dimensional_scrollables] Fixes TreeViewNode collapsing not working (flutter/packages#7474) 2024-10-17 stuartmorgan@google.com Revert "[in_app_purchase_storekit] Add support for purchase and transactions #7574" (flutter/packages#7886) 2024-10-17 109111084+yaakovschectman@users.noreply.github.com [camera_android] Mark `description` in `sendCameraErrorEvent` as `@NonNull` (flutter/packages#7877) 2024-10-17 chris@bracken.jp [image_picker_web] Loosen mime dep to >=1.0.4 <3.0.0 (flutter/packages#7879) 2024-10-17 52160996+FMorschel@users.noreply.github.com Removing unnecessary parenthesis (flutter/packages#7881) 2024-10-17 louisehsu@google.com [in_app_purchase_storekit] Add support for purchase and transactions #7574 (flutter/packages#7812) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR contains the preliminary implementations for handling purchases and transactions
Of note, as of StoreKit 2, the result of a call to a purchase will only return a Transaction when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned.
This is in contrast to StoreKit 1, where developers could check the state of a Transaction with TransactionState. This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly.
Relands #7574
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.