-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_adsense_ad_placement_api_web] Creates new package to simplify interaction with AdSense Ad Placement API for Flutter Apps #7747
Draft
astivi
wants to merge
22
commits into
flutter:main
Choose a base branch
from
astivi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astivi
changed the title
[google_adsense_ad_placement_api] Creates new package to simplify interaction with AdSense Ad Placement API for Flutter Apps
[google_adsense_ad_placement_api_web] Creates new package to simplify interaction with AdSense Ad Placement API for Flutter Apps
Oct 1, 2024
Adding myself to this so I can take a look! @astivi, is this something you want to merge or are still working on it? |
I was going to suggest that, or at least to share some code (for example the installing of the JS library). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official library release to simplify monetization of Flutter Apps by providing an easy to use interface to the AdSense Ad Placement API in the Web platform.
Please note that this package only supports interacting with the Ad Placement API after it's already loaded. Before using it remember to include the appropriate adsense js files.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.