Skip to content

Modernize the rest of the index.html files to support WASM compilation #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2024
Merged

Modernize the rest of the index.html files to support WASM compilation #7192

merged 7 commits into from
Jul 25, 2024

Conversation

Rexios80
Copy link
Member

Turns out there are a bunch of other index.html files that used a different method of Flutter initialization

flutter/flutter#151663

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Rexios80
Rexios80 commented Jul 22, 2024
View reviewed changes
@stuartmorgan-g
Copy link
Contributor

test-exempt: configuration change

CHANGELOG override: mechanical change to example plumbing to bring it up to current standard.

Note that you will need a version and CHANGELOG change where you have changed the README.

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jul 22, 2024
@Rexios80 Rexios80 mentioned this pull request Jul 24, 2024
Merged
ditman
ditman approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If web CI passes this should be good to go!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit Auto-submit

This comment was marked as outdated.

Sign in to view
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@ditman
Copy link
Member

ditman commented Jul 25, 2024

Ouch! I need another approval /cc @stuartmorgan

stuartmorgan-g
stuartmorgan-g approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot merged commit 19daf6f into flutter:main Jul 25, 2024
76 checks passed
@stuartmorgan-g
Copy link
Contributor

@Rexios80 Please feel free to ping me on Discord if you would like to be nominated for contributor access!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
19daf6f Modernize the rest of the index.html files to support WASM …
c363f4e 
…compilation (flutter/packages#7192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
19daf6f Modernize the rest of the index.html files to support WASM …
9a83fb1 
…compilation (flutter/packages#7192)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
Roll Packages from 1c319ac to 19daf6f (3 revisions) (#152327)
9be3753 
flutter/packages@1c319ac...19daf6f

2024-07-25 rexios@rexios.dev Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192)
2024-07-25 robert.ancell@canonical.com Add Linux support to Pigeon (flutter/packages#5100)
2024-07-24 ditman@gmail.com [gis_web] Allow package:web 1.0.0 (flutter/packages#7203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from 1c319ac to 19daf6f (3 revisions) (flutter#152327)
70ebeed 
flutter/packages@1c319ac...19daf6f

2024-07-25 rexios@rexios.dev Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192)
2024-07-25 robert.ancell@canonical.com Add Linux support to Pigeon (flutter/packages#5100)
2024-07-24 ditman@gmail.com [gis_web] Allow package:web 1.0.0 (flutter/packages#7203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from 1c319ac to 19daf6f (3 revisions) (flutter#152327)
44c151c 
flutter/packages@1c319ac...19daf6f

2024-07-25 rexios@rexios.dev Modernize the rest of the `index.html` files to support WASM compilation (flutter/packages#7192)
2024-07-25 robert.ancell@canonical.com Add Linux support to Pigeon (flutter/packages#5100)
2024-07-24 ditman@gmail.com [gis_web] Allow package:web 1.0.0 (flutter/packages#7203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

@Piinks Piinks Awaiting requested review from Piinks Piinks is a code owner

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: camera p: extension_google_sign_in_as_googleapis_auth p: flutter_adaptive_scaffold p: flutter_image p: google_maps_flutter p: google_sign_in p: pointer_interceptor platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rexios80 @stuartmorgan-g @ditman