[interactive_media_ads] Updates `README` with a usage section and fix some interface docs #6988

bparrishMines · 2024-06-25T17:58:25Z

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bparrishMines · 2024-06-25T18:23:07Z

packages/interactive_media_ads/README.md

Convenience link to see preview: https://github.com/bparrishMines/packages/blob/ima_readme/packages/interactive_media_ads/README.md

stuartmorgan-g

LGTM

stuartmorgan-g · 2024-06-27T12:07:57Z

packages/interactive_media_ads/README.md

+
+1. Add Android Required Permissions
+
+If building on Android, add the user permissions required by the IMA SDK for requesting ads in


If you are going to use a bulleted list for the headings, I would make all of the content part of the list (by indenting everything in this entire section by two spaces), so that the content of each section isn't offset further left than its heading.

Alternatively, you could do ### 1. Add Android Required Permissions, etc.

stuartmorgan-g · 2024-06-27T12:09:02Z

packages/interactive_media_ads/lib/src/ad_display_container.dart

@@ -7,7 +7,7 @@ import 'package:flutter/cupertino.dart';
 import 'platform_interface/platform_ad_display_container.dart';
 import 'platform_interface/platform_interface.dart';

-/// Handles playing ads after they've been received from the server.
+/// A `Widget` for displaying loaded ads.


[Widget]?

stuartmorgan-g · 2024-06-27T12:09:51Z

packages/interactive_media_ads/lib/src/ads_loader.dart

@@ -92,6 +93,10 @@ class AdsLoader {
  }

  /// Requests ads from a server.
+  ///
+  /// Note that ads cannot be request until the `AdDisplayContainer` has been


Just "Ads cannot be [...]", per Flutter style guide, per https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#avoid-empty-prose

stuartmorgan-g · 2024-06-27T12:09:56Z

packages/interactive_media_ads/lib/src/ads_loader.dart

@@ -92,6 +93,10 @@ class AdsLoader {
  }

  /// Requests ads from a server.
+  ///
+  /// Note that ads cannot be request until the `AdDisplayContainer` has been


Typo: requested

… and fix some interface docs (flutter/packages#6988)

flutter/packages@03f5f6d...412ec46 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.10 (flutter/packages#6924) 2024-06-27 ditman@gmail.com [video_player] Exposes VideoPlayerWebOptions. (flutter/packages#6990) 2024-06-27 ditman@gmail.com [ci] Add Wasm compilation to all_packages web app. (flutter/packages#6981) 2024-06-27 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Updates `README` with a usage section and fix some interface docs (flutter/packages#6988) 2024-06-27 stuartmorgan@google.com [tools] Fix vm test requirement (flutter/packages#6995) 2024-06-27 jacksongardner@google.com Update `web_benchmarks` package to properly support wasm. (flutter/packages#6970) 2024-06-27 stuartmorgan@google.com [pigeon] Implement equals for Java data classes (flutter/packages#6992) 2024-06-25 matanlurey@users.noreply.github.com Final refactor of `video_player_android` before `SurfaceProducer#setCallback`. (flutter/packages#6982) 2024-06-25 stuartmorgan@google.com [pigeon] Update testing and docs (flutter/packages#6984) 2024-06-25 parlough@gmail.com [various] Update flutter.dev links to more reliable destinations (flutter/packages#6963) 2024-06-25 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds initial Android implementation (flutter/packages#6733) 2024-06-25 engine-flutter-autoroll@skia.org Roll Flutter from 6c06abb to e726eb4 (51 revisions) (flutter/packages#6987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bparrishMines added 30 commits April 26, 2024 14:35

get libraries to generate

9f02730

add a bunch of classes

5f767fb

some more videview stuff

b3317a0

some display implementation for android

631c1e0

add the minimum required wrappings

35a4445

fix build error

8ac0311

implement other platform classes

bc4d770

start creating an implementation

1f74ead

move interfaces to bottom and format

4320f50

fix callback events

e85027d

remove prints

6739d7f

fix removeStrongReference error

e803962

Merge branch 'main' of github.com:flutter/packages into ima_android

0d59a8e

also send time updates

6b22ebc

combine implementation files

957e2ba

fix lint warnings

d0be873

fix Android dartPluginClass

875d6be

fix missing params call

0122f6c

make tracking ad progress in ad display container

d0971db

Merge branch 'main' of github.com:flutter/packages into ima_android

6b8ee3a

add missing error codes

b1ace40

discard ad break

cc728d2

licenses

f345071

copyright header

90965aa

first test file

93c239b

working tests

c1b00f1

more working tests

dce1723

more tests

76af339

media player test

c2d6f67

Merge branch 'main' of github.com:flutter/packages into ima_android

9dde9d6

bparrishMines added 6 commits June 24, 2024 21:34

formatting and lint

6a18fac

only run example on Android

4829c85

small nits

463bfe4

Merge branch 'main' of github.com:flutter/packages into ima_readme

ca22c23

update readme and some bad docs

0a7bebd

version bump

98bb920

github-actions bot added the platform-android label Jun 25, 2024

bparrishMines added 5 commits June 25, 2024 14:05

actually count and mention pubspec

1605042

fix counts and other thing

f8677d3

some more readme fixes

c939551

improve docs some

fa53978

five not four

de84612

bparrishMines commented Jun 25, 2024

View reviewed changes

fix changelog

b37e4f6

bparrishMines changed the title ~~Ima readme~~ [interactive_media_ads] Updates README with a usage section and fix some interface docs Jun 25, 2024

bparrishMines requested a review from stuartmorgan-g June 25, 2024 19:32

stuartmorgan-g approved these changes Jun 27, 2024

View reviewed changes

review comments

9aea125

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2024

auto-submit bot merged commit 62e1963 into flutter:main Jun 27, 2024
74 checks passed

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Packages from 03f5f6d5660c to 62e1963cf7ec (9 revisions) flutter/flutter#150934

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2024

62e1963 [interactive_media_ads] Updates README with a usage section…

308587b

… and fix some interface docs (flutter/packages#6988)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Packages from 03f5f6d5660c to 62e1963cf7ec (9 revisions) flutter/flutter#150949

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2024

62e1963 [interactive_media_ads] Updates README with a usage section…

a036e8f

… and fix some interface docs (flutter/packages#6988)

bparrishMines deleted the ima_readme branch June 27, 2024 23:50

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Packages from 03f5f6d5660c to 412ec4615aa4 (12 revisions) flutter/flutter#150985

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 28, 2024

62e1963 [interactive_media_ads] Updates README with a usage section…

49ecd5c

… and fix some interface docs (flutter/packages#6988)

reidbaker mentioned this pull request Jul 2, 2024

i151188 update espresso dependencies v2 reidbaker/packages#6

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[interactive_media_ads] Updates `README` with a usage section and fix some interface docs #6988

[interactive_media_ads] Updates `README` with a usage section and fix some interface docs #6988

Uh oh!

bparrishMines commented Jun 25, 2024 •

edited

Loading

Uh oh!

bparrishMines Jun 25, 2024 •

edited

Loading

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Jun 27, 2024

Uh oh!

stuartmorgan-g Jun 27, 2024

Uh oh!

stuartmorgan-g Jun 27, 2024

Uh oh!

stuartmorgan-g Jun 27, 2024

Uh oh!

Uh oh!

Uh oh!


		1. Add Android Required Permissions

		If building on Android, add the user permissions required by the IMA SDK for requesting ads in

[interactive_media_ads] Updates README with a usage section and fix some interface docs #6988

[interactive_media_ads] Updates README with a usage section and fix some interface docs #6988

Uh oh!

Conversation

bparrishMines commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

bparrishMines Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[interactive_media_ads] Updates `README` with a usage section and fix some interface docs #6988

[interactive_media_ads] Updates `README` with a usage section and fix some interface docs #6988

bparrishMines commented Jun 25, 2024 •

edited

Loading

bparrishMines Jun 25, 2024 •

edited

Loading