Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented May 29, 2024

This is in response to #6371 (comment)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title Pigeon dart instance manager api [pigeon] Updates PigeonInstanceMangerApi to use the shared api channel code in Dart May 29, 2024
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024
@auto-submit auto-submit bot merged commit 9ad2327 into flutter:main May 30, 2024
@bparrishMines bparrishMines deleted the pigeon_dart_instanceManagerApi branch May 30, 2024 16:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 31, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 31, 2024
flutter/packages@910fabb...d8e8e8c

2024-05-31 linxunfeng@yeah.net [image_picker] Adds comment for the limit parameter (flutter/packages#6678)
2024-05-30 jonahwilliams@google.com Revert "Migrate CameraX from SurfaceTexture to SurfaceProducer." (flutter/packages#6838)
2024-05-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Updates `PigeonInstanceMangerApi` to use the shared api channel code in Dart (flutter/packages#6831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@910fabb...d8e8e8c

2024-05-31 linxunfeng@yeah.net [image_picker] Adds comment for the limit parameter (flutter/packages#6678)
2024-05-30 jonahwilliams@google.com Revert "Migrate CameraX from SurfaceTexture to SurfaceProducer." (flutter/packages#6838)
2024-05-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Updates `PigeonInstanceMangerApi` to use the shared api channel code in Dart (flutter/packages#6831)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants