[rfw] Adds support for DecorationImage.filterQuality.
#6781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
changed the title
DecorationImage.filterQuality.
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2024
flutter/packages@6525441...1008d9e 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 73bf206 to 8d955cd (24 revisions) (flutter/packages#6786) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 5dcb86f to a14f74f (3 revisions) (flutter/packages#6784) 2024-05-23 stuartmorgan@google.com [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755) 2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter/packages#6780) 2024-05-23 goderbauer@google.com [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@6525441...1008d9e 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 73bf206 to 8d955cd (24 revisions) (flutter/packages#6786) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 5dcb86f to a14f74f (3 revisions) (flutter/packages#6784) 2024-05-23 stuartmorgan@google.com [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755) 2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996) 2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter/packages#6780) 2024-05-23 goderbauer@google.com [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And hard-codes filter qualities in tests to prepare for flutter/flutter#148799, which switches the default to
medium. This hard-codes a filter quality in the test so the test passes no matter what the default is.