[pigeon] a few tweaks to the output after having upgraded video_player #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
approved these changes
Feb 4, 2022
packages/pigeon/bin/run_tests.dart
Outdated
| @@ -7,7 +7,7 @@ | |||
| /// | |||
| /// usage: pub run pigeon:run_tests | |||
| //////////////////////////////////////////////////////////////////////////////// | |||
| import 'dart:io' show Process, Platform, exit, stdout, stderr; | |||
| import 'dart:io' show Process, Platform, exit, stdout, stderr, File; | |||
There was a problem hiding this comment.
Nit: how about grouping the classes and variables, rather than just using whatever order they were added in.
There was a problem hiding this comment.
Done, it might be worth putting in a feature request for the dart team.
packages/pigeon/bin/run_tests.dart
Outdated
| // Delete these files that were just generated to help with the analyzer step. | ||
| File('$flutterUnitTestsPath/lib/message.gen.dart').deleteSync(); | ||
| File('$flutterUnitTestsPath/test/message_test.dart').deleteSync(); | ||
|
|
There was a problem hiding this comment.
Please use local variables for these paths instead of repeating the construction twice.
There was a problem hiding this comment.
Also, this whole new block seems like it would be much better as a separate method, so that it's clear that it's a self-contained block that's unrelated to the code above and below (e.g., Future<int> _analyzeGeneratedCode(String path)). That would make this method easier to follow since it would be higher level..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some pigeon issues that surfaced in flutter/plugins#4726
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.