Update local_auth_android minSdkVersion to 19 #6537

stuartmorgan-g · 2024-04-15T15:38:14Z

#6506 was supposed to update everything to 19+, but missed local_auth_android. This updates it to require 19 as well.

#6506 was supposed to update everything to 19+, but missed local_auth_android. PRs are now failing lint in this package because the example is trying to build with 16 but dependencies use 19.

flutter-dashboard · 2024-04-15T15:38:17Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g · 2024-04-15T15:38:55Z

test-exempt: configuration change

(Also, does fix a broken test)

stuartmorgan-g · 2024-04-15T15:41:22Z

Example OOB presubmit failure this fixes: #5523 (comment)

reidbaker · 2024-04-15T15:45:38Z

packages/local_auth/local_auth_android/android/build.gradle


    defaultConfig {
-        minSdkVersion 16
+        minSdkVersion flutter.minSdkVersion


I think this needs to be a 19

A lot of our existing examples use flutter.minSdkVersion; I thought we only wanted to use a number when a specific example needed something higher than the min (e.g., the example for a plugin that requires 21).

Wait, this isn't the /app/ file. Why is this line even here? I need to look at this again, I missed the path on this.

I believe the plugins don't have an app subdirectory so their minSdkVersion lives in the top level build.gradle.

But also the flutter gradle plugin doesn't get applied, so you can't use flutter.minSdkVersion

Oh, it's not the example, it's the actual plugin. I really can't read this morning.

Now I'm confused as to what's causing the error in the example app though. This should probably be 19 and get a version bump, but the example app is already using flutter.minSdkVersion.

stuartmorgan-g · 2024-04-15T16:30:04Z

I've updated this so it should be a correct change now, but I'm still not sure why the presubmit errors are happening in other PRs...

stuartmorgan-g · 2024-04-15T16:33:30Z

Okay, I think I see now. The error message had example in the build path because that's where we run the command, but the failing target was in local_auth_android itself, not the example, so it looks like the issue was that local_auth_android was trying to depend on another plugin (flutter_plugin_android_lifecycle) that required 19.

gmackall · 2024-04-15T16:39:24Z

So for my understanding, the reason why presubmits wouldn't have caught this on my PR is that the lint step here would have been running against the latest published version of flutter_plugin_android_lifecycle at the time (not the version that was modified in the PR)?

stuartmorgan-g · 2024-04-15T16:47:17Z

Correct. We don't do a pathified version of native testing because it would be really expensive, and it's rarely a problem, but it's something we could reconsider.

(What I really wish was that we had an easy way to do optional tests, like being able to manually trigger pathified native Android tests on a PR like yours. Maybe we could do some trickery with a dummy path and path-based rules...)

…es#6537)

flutter/packages@6698b2d...90c876d 2024-04-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.10 to 3.25.0 (flutter/packages#6545) 2024-04-16 31859944+LongCatIsLooong@users.noreply.github.com [CupertinoIcons] fix broken icons and vertical alignment, bump the version to 1.08 (flutter/packages#6520) 2024-04-16 26625149+0xZOne@users.noreply.github.com [video_player] Calls `onDestroy` instead of `initialize` in onDetachedFromEngine (flutter/packages#6501) 2024-04-15 mikemcguiness@protonmail.com [image_picker] Adopt code excerpts in README (flutter/packages#5523) 2024-04-15 mdebbar@google.com [url_launcher][web] Link should work when triggered by keyboard (flutter/packages#6505) 2024-04-15 engine-flutter-autoroll@skia.org Manual roll Flutter from 53cba24 to 2e748e8 (19 revisions) (flutter/packages#6541) 2024-04-15 stuartmorgan@google.com Update local_auth_android minSdkVersion to 19 (flutter/packages#6537) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter#6506 was supposed to update everything to 19+, but missed local_auth_android. This updates it to require 19 as well.

Fix local_auth_android example minSdkVersion

46da1e2

#6506 was supposed to update everything to 19+, but missed local_auth_android. PRs are now failing lint in this package because the example is trying to build with 16 but dependencies use 19.

stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Apr 15, 2024

stuartmorgan-g requested a review from camsim99 as a code owner April 15, 2024 15:38

github-actions bot added p: local_auth platform-android labels Apr 15, 2024

stuartmorgan-g requested review from gmackall and reidbaker April 15, 2024 15:40

reidbaker approved these changes Apr 15, 2024

View reviewed changes

stuartmorgan-g removed override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Apr 15, 2024

Fix to be correct for bumping the actual plugin version

c872085

stuartmorgan-g changed the title ~~Fix local_auth_android example minSdkVersion~~ Update local_auth_android minSdkVersion to 19 Apr 15, 2024

gmackall approved these changes Apr 15, 2024

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024

reidbaker approved these changes Apr 15, 2024

View reviewed changes

auto-submit bot merged commit 365d675 into main Apr 15, 2024

auto-submit bot deleted the local-auth-android-example-min-19 branch April 15, 2024 16:49

engine-flutter-autoroll mentioned this pull request Apr 16, 2024

Roll Packages from 6698b2d67999 to 701d60a08941 (6 revisions) flutter/flutter#146824

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 16, 2024

365d675 Update local_auth_android minSdkVersion to 19 (flutter/packag…

2f72077

…es#6537)

engine-flutter-autoroll mentioned this pull request Apr 16, 2024

Roll Packages from 6698b2d67999 to 90c876d37619 (7 revisions) flutter/flutter#146835

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 16, 2024

365d675 Update local_auth_android minSdkVersion to 19 (flutter/packag…

1670aaa

…es#6537)

Update local_auth_android minSdkVersion to 19 #6537

Update local_auth_android minSdkVersion to 19 #6537

Uh oh!

Conversation

stuartmorgan-g commented Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Apr 15, 2024

Uh oh!

stuartmorgan-g commented Apr 15, 2024

Uh oh!

stuartmorgan-g commented Apr 15, 2024

Uh oh!

reidbaker Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

gmackall Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Apr 15, 2024

Uh oh!

stuartmorgan-g commented Apr 15, 2024

Uh oh!

gmackall commented Apr 15, 2024

Uh oh!

stuartmorgan-g commented Apr 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stuartmorgan-g commented Apr 15, 2024 •

edited

Loading