-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ci] Adds sleep 60s to release action. #6405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure how to test this locally, since this is configuration for a post-submit action! |
stuartmorgan-g
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As suggested in #137299: * Adds a 1 minute sleep to our `release.yml` workflow so LUCI checks have time to be populated through the GitHub Webhooks, before attempting to look at them. This will make the `release` action a little bit slower, but hopefully much more reliable.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2024
flutter/packages@924c7e6...51faaa1 2024-03-29 krupikivan@gmail.com [shared_preferences] Update mockito to the new version available 5.2.0 (flutter/packages#6332) 2024-03-29 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 68bfaea to 300451a (2 revisions) (flutter/packages#6433) 2024-03-28 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /packages/image_picker/image_picker_android/android (flutter/packages#5705) 2024-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from dbdcead to 89ea492 (54 revisions) (flutter/packages#6431) 2024-03-28 ditman@gmail.com [ci] Adds sleep 60s to release action. (flutter/packages#6405) 2024-03-28 112062427+anisovdev@users.noreply.github.com [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs (flutter/packages#6236) 2024-03-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Reland "Creates and adds the interactive_media_ads plugin #6060" (flutter/packages#6425) 2024-03-28 ditman@gmail.com [google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. (flutter/packages#6430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in flutter/flutter#137299:
release.yml
workflow so LUCI checks have time to be populated through the GitHub Webhooks, before attempting to look at them.This will make the
release
action a little bit slower, but hopefully much more reliable.Issues
release
sometimes fails due to slow task check-in flutter#137299Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.