Skip to content

[ci] Adds sleep 60s to release action. #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[ci] Adds sleep 60s to release action. #6405

merged 1 commit into from
Mar 28, 2024

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 26, 2024

As suggested in flutter/flutter#137299:

  • Adds a 1 minute sleep to our release.yml workflow so LUCI checks have time to be populated through the GitHub Webhooks, before attempting to look at them.

This will make the release action a little bit slower, but hopefully much more reliable.

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g March 26, 2024 21:58
@ditman
Copy link
Member Author

ditman commented Mar 26, 2024

Unsure how to test this locally, since this is configuration for a post-submit action!

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As suggested in #137299:

* Adds a 1 minute sleep to our `release.yml` workflow so LUCI checks have time to be populated through the GitHub Webhooks, before attempting to look at them.

This will make the `release` action a little bit slower, but hopefully much more reliable.
@ditman ditman added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Mar 28, 2024
@auto-submit auto-submit bot merged commit 6d86800 into main Mar 28, 2024
@auto-submit auto-submit bot deleted the ditman-patch-1 branch March 28, 2024 21:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 29, 2024
flutter/packages@924c7e6...51faaa1

2024-03-29 krupikivan@gmail.com [shared_preferences] Update mockito to the new version available 5.2.0 (flutter/packages#6332)
2024-03-29 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 68bfaea to 300451a (2 revisions) (flutter/packages#6433)
2024-03-28 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /packages/image_picker/image_picker_android/android (flutter/packages#5705)
2024-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from dbdcead to 89ea492 (54 revisions) (flutter/packages#6431)
2024-03-28 ditman@gmail.com [ci] Adds sleep 60s to release action. (flutter/packages#6405)
2024-03-28 112062427+anisovdev@users.noreply.github.com [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs (flutter/packages#6236)
2024-03-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Reland "Creates and adds the interactive_media_ads plugin #6060" (flutter/packages#6425)
2024-03-28 ditman@gmail.com [google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. (flutter/packages#6430)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter/packages release sometimes fails due to slow task check-in
2 participants