Skip to content

[ci] Reduce tasks slightly #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Help buy a bit of time until we eliminate the max number of tasks for release to wait for, and be more efficient with CI resources:

  • Folds the very fast repo-tooling-unit-test step into the existing repo checks task, cutting down on machine overhead.
  • Removes the master version of downgraded analysis, since it's hard to imagine a plausible scenario where it fails but the stable version does not, so we don't need to spend resources on both.

See flutter/flutter#141196

Help buy a bit of time until we eliminate the max number of tasks for
`release` to wait for, and be more efficient with CI resources:
- Folds the very fast repo-tooling-unit-test step into the existing repo
  checks task, cutting down on machine overhead.
- Removes the `master` version of downgraded analysis, since it's hard
  to imagine a plausible scenario where it fails but the `stable`
  version does not, so we don't need to spend resources on both.

See flutter/flutter#141196
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2024
Copy link
Contributor

auto-submit bot commented Jan 29, 2024

auto label is removed for flutter/packages/6011, due to - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@@ -2,6 +2,8 @@ tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: tool unit tests
script: .ci/scripts/plugin_tools_tests.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the note above, should this one be an infra_step: true as well?

@auto-submit auto-submit bot merged commit 724f52d into flutter:main Jan 30, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 30, 2024
flutter/packages@516648a...25abb5d

2024-01-30 tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807)
2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011)
2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010)
2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009)
2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa77 to 2f6fdf2 (23 revisions) (flutter/packages#6008)
2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants