-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[pigeon] Improve style of generated Swift code #5938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] Improve style of generated Swift code #5938
Conversation
Let me know if you want me to revert the two special-case style things at the end of the list. I went back and forth on whether to write them, and still don't feel strongly either way. |
I actually would prefer to keep those implementations as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me, thanks @stuartmorgan
auto label is removed for flutter/packages/5938, due to - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@129e08c...e4cbf23 2024-01-21 engine-flutter-autoroll@skia.org Roll Flutter from ddf60fb to 5dea6b9 (5 revisions) (flutter/packages#5951) 2024-01-21 stuartmorgan@google.com Update platform label rules for shared iOS/macOS (flutter/packages#5801) 2024-01-20 stuartmorgan@google.com [pigeon] Support other hosts in generated file CI checks (flutter/packages#5944) 2024-01-20 stuartmorgan@google.com [pigeon] Improve style of generated Swift code (flutter/packages#5938) 2024-01-20 engine-flutter-autoroll@skia.org Roll Flutter from 684247a to ddf60fb (12 revisions) (flutter/packages#5949) 2024-01-20 41930132+hellohuanlin@users.noreply.github.com [camera]fix a sample buffer memory leak on pause resume recording (flutter/packages#5927) 2024-01-19 magder@google.com [ci] Run Swift formatter and linter during CI formatting (flutter/packages#5928) 2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f77f824 to 684247a (39 revisions) (flutter/packages#5948) 2024-01-19 john@johnmccutchan.com Expose registered widget libraries and local widget library widgets. (flutter/packages#5936) 2024-01-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.1.0 to 4.2.0 (flutter/packages#5937) 2024-01-19 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ef1af02 to 67457e6 (1 revision) (flutter/packages#5932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cleans up our Swift output to be more idiomatic (or in a couple of cases to match swift-format` in particular):
case
s inswitch
es.;
s()
s aroundif
conditions()
and{
)#if
constructs.swift-format
-style (and they add branching to the generator that would otherwise not be needed):()
on zero-arg method calls with a trailing closureWith these changes, as far as can tell the diffs created by
swift-format
are just line wrapping.Fixes flutter/flutter#141799
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).