-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[tool] Use ^ for Dart SDK #5623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The update-min-sdk command has been using explicitly ranges for the Dart SDK, because that used to be required. Current versions of `pub` no longer require that, and using `^` for Dart ranges is okay, so this updates the tooling to use that format in the future. To minimize churn, this doesnn't update the existing pubspecs. We can incrementally adopt this going forward as we roll dependencies forward. Fixes flutter/flutter#139806
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flutter
constraint forbids an upper range, so we're going to end up with something like this:
sdk: ^3.2.0
flutter: ">=3.16.0"
(which had me doing a double take to grok why they're different :P)
Yes, but they were also different before (Dart requires upper bound, Flutter forbids it), so it's just differently different :) |
Agreed, the |
The tree thinks that it needs to be red: ![]() But in reality, build 605 passed. The dashboard must have lost the memo. (Manually squashing and merging this PR to get the dashboard unstuck.) |
flutter/packages@6cd0657...cb6dbcd 2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529) 2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623) 2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612) 2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629) 2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614) 2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619) 2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625) 2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580) 2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The update-min-sdk command has been using explicitly ranges for the Dart SDK, because that used to be required. Current versions of
pub
no longer require that, and using^
for Dart ranges is okay, so this updates the tooling to use that format in the future.Also removes the special casing that changed the upper bound from 3 to 4, since we have passed the point where we are generating upper bounds less than 4 anyway.
To minimize churn, this doesn't update the existing pubspecs. We can incrementally adopt this going forward as we roll dependencies forward.
Fixes flutter/flutter#139806