Skip to content

[tool] Use ^ for Dart SDK #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Conversation

stuartmorgan-g
Copy link
Contributor

The update-min-sdk command has been using explicitly ranges for the Dart SDK, because that used to be required. Current versions of pub no longer require that, and using ^ for Dart ranges is okay, so this updates the tooling to use that format in the future.

Also removes the special casing that changed the upper bound from 3 to 4, since we have passed the point where we are generating upper bounds less than 4 anyway.

To minimize churn, this doesn't update the existing pubspecs. We can incrementally adopt this going forward as we roll dependencies forward.

Fixes flutter/flutter#139806

The update-min-sdk command has been using explicitly ranges for the Dart
SDK, because that used to be required. Current versions of `pub` no
longer require that, and using `^` for Dart ranges is okay, so this
updates the tooling to use that format in the future.

To minimize churn, this doesnn't update the existing pubspecs. We can
incrementally adopt this going forward as we roll dependencies forward.

Fixes flutter/flutter#139806
@stuartmorgan-g stuartmorgan-g requested a review from ditman December 8, 2023 17:29
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flutter constraint forbids an upper range, so we're going to end up with something like this:

sdk: ^3.2.0
flutter: ">=3.16.0"

(which had me doing a double take to grok why they're different :P)

@stuartmorgan-g
Copy link
Contributor Author

Yes, but they were also different before (Dart requires upper bound, Flutter forbids it), so it's just differently different :)

@ditman
Copy link
Member

ditman commented Dec 8, 2023

Yes, but they were also different before (Dart requires upper bound, Flutter forbids it), so it's just differently different :)

Agreed, the flutter dependency now sticks out a little bit. Maybe we should propose a prefix so ∞3.16.0 means "anything after 3.16.0, with no upper bound" :P

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2023
@ditman
Copy link
Member

ditman commented Dec 9, 2023

The tree thinks that it needs to be red:

Screenshot 2023-12-08 at 8 36 17 PM

But in reality, build 605 passed.

The dashboard must have lost the memo.

(Manually squashing and merging this PR to get the dashboard unstuck.)

@ditman ditman merged commit 51174d1 into flutter:main Dec 9, 2023
@ditman
Copy link
Member

ditman commented Dec 9, 2023

OK, it seems that the dashboard will retry 3x automatically without us having to use the github UI. In fact, it seems the dashboard is not picking up the retries triggered from the github UI?

If the above is true, the retries for LUCI tasks that are "red" should be triggered from the RERUN button of the dashboard, and not github. Like I did here for testing:

Screenshot 2023-12-08 at 10 00 14 PM

(Note how run 605 is not listed there)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
flutter/packages@6cd0657...cb6dbcd

2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered  by a user action (flutter/packages#5143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[packages] Update Dart SDK constraints to ^ notation
2 participants