Skip to content

[path_provider_android] Disable getExternalStorageDirectories (type: ...) test #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Dec 8, 2023

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Dec 8, 2023

Disables the getExternalStorageDirectories (type: ...) integration test in path_provider_android that is extremely flaky (particularly on AVDs running Android 34) to reduce the impact it has had on developer productivity.

Fixes flutter/flutter#139378.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

camsim99 added 30 commits May 1, 2023 16:46
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2023
@gmackall
Copy link
Member

gmackall commented Dec 8, 2023

By the way I think the tree is red on the flake that this fixes. Just a heads up if we want to land on red

@stuartmorgan-g
Copy link
Contributor

It's also red on an OOB iOS maps issue that we're still tracking down, but yes, this is fine to land on red since it's fixing tree failures.

@stuartmorgan-g stuartmorgan-g added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Dec 8, 2023
@auto-submit auto-submit bot merged commit b7bf037 into flutter:main Dec 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
flutter/packages@6cd0657...cb6dbcd

2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered  by a user action (flutter/packages#5143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: path_provider platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux_android android_platform_tests_shard_4 failing frequently
3 participants