Skip to content

Add example app #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jemishavasoya
Copy link

added simple example app for it that demonstrates

[css_color] Add example app #136217
#136217

added Example app

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@stuartmorgan-g
Copy link
Contributor

  • All existing and new tests are passing.

Since a large number of CI checks are failing, I'm assuming this is a work in progress, and marking it as a Draft accordingly, Please mark it as ready for review once it's passing.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft November 28, 2023 19:46
@stuartmorgan-g stuartmorgan-g removed their request for review November 28, 2023 19:46
@jemishavasoya jemishavasoya marked this pull request as ready for review November 30, 2023 17:45
@stuartmorgan-g
Copy link
Contributor

[css_color] Add example app #136217
#136217

The referenced issue is about a completely different package.

What's the goal of adding this example app? It's not clear to me what this is accomplishing that the README doesn't (and/or than a simple example.md wouldn't do). We don't need integration tests, for instance.

@camsim99
Copy link
Contributor

@jemishavasoya when you get a chance, can you clarify the goal of adding this example? Converting to a draft in the meantime to remove this from our queue.

@camsim99 camsim99 marked this pull request as draft December 14, 2023 19:24
@goderbauer
Copy link
Member

(triage): @jemishavasoya Do you still have plans to get back to this PR in the near future to address the feedback given above?

@stuartmorgan-g
Copy link
Contributor

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants