-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add example app #5512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example app #5512
Conversation
Since a large number of CI checks are failing, I'm assuming this is a work in progress, and marking it as a Draft accordingly, Please mark it as ready for review once it's passing. |
…om/jemishavasoya/packages into css_colors-add-example-app-#136217
…om/jemishavasoya/packages into css_colors-add-example-app-#136217
The referenced issue is about a completely different package. What's the goal of adding this example app? It's not clear to me what this is accomplishing that the README doesn't (and/or than a simple example.md wouldn't do). We don't need integration tests, for instance. |
@jemishavasoya when you get a chance, can you clarify the goal of adding this example? Converting to a draft in the meantime to remove this from our queue. |
(triage): @jemishavasoya Do you still have plans to get back to this PR in the near future to address the feedback given above? |
Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks! |
added simple example app for it that demonstrates
[css_color] Add example app #136217
#136217
added Example app
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).