[flutter_image] Adopt code excerpts in README #5498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
LGTM with comment nits. Thanks!
(This is a case where we could potentially rework the actual example code some and then excerpt from that, instead of having a special-purpose file, but I don't think it's worth the churn of adding another image to the example.)
|
@tarrinneal for secondary review. |
tarrinneal
approved these changes
Nov 29, 2023
tarrinneal
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5498, due to - The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/5498, due to - The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 4, 2023
flutter/packages@bc72d15...5d9874f 2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter from 918e336 to d861ce4 (29 revisions) (flutter/packages#5542) 2023-12-02 ditman@gmail.com [gsi_web] Do not initialize CodeClient if scopes are empty. (flutter/packages#5537) 2023-12-01 15619084+vashworth@users.noreply.github.com Reenable macOS 13 tests (flutter/packages#5494) 2023-12-01 mikemcguiness@protonmail.com [flutter_image] Adopt code excerpts in README (flutter/packages#5498) 2023-11-30 kevmoo@users.noreply.github.com [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter/packages#5520) 2023-11-30 stuartmorgan@google.com [google_maps_flutter] Add support for version 8 of the iOS SDK (flutter/packages#5528) 2023-11-30 stuartmorgan@google.com [pointer_interceptor] Re-land: Add platform interface (flutter/packages#5525) 2023-11-30 61667947+T-P-F@users.noreply.github.com [google_sign_in] Add server auth code retrieval to gis_client (flutter/packages#5358) 2023-11-30 engine-flutter-autoroll@skia.org Roll Flutter from 5e5b529 to 918e336 (14 revisions) (flutter/packages#5526) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the README to use a compiled excerpt source for its example of using
NetworkImageWithRetry.Part of flutter/flutter#102679
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.