[url_launcher] Fix launch mode types in new APIs #5232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new query APIs added in 6.2.0 accidentally used `PreferredLaunchMode`, which is only intended for the platform interface layer, rather than `LaunchMode`, which is the app-facing analog (they are separate to allow controlling when each is updated separately). Technically this is a breaking change, but 6.2.0 was out for less than 24 hours, so very few people will be affected, and a breaking change to fix this would have much more disruptive effects on the ecosystem. Fixes flutter/flutter#137278
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 26, 2023
flutter/packages@f751ffb...fea24c5 2023-10-25 stuartmorgan@google.com [url_launcher] Fix launch mode types in new APIs (flutter/packages#5232) 2023-10-25 43054281+camsim99@users.noreply.github.com [camerax] Implement `setZoomLevel` (flutter/packages#4950) 2023-10-25 engine-flutter-autoroll@skia.org Roll Flutter from 5e8b5f4 to 5dd2a4e (59 revisions) (flutter/packages#5231) 2023-10-25 43054281+camsim99@users.noreply.github.com [file_selector_android] Run tests on AVDs running Android 34 (flutter/packages#5218) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new query APIs added in 6.2.0 accidentally used
PreferredLaunchMode, which is only intended for the platform interface layer, rather thanLaunchMode, which is the app-facing analog (they are separate to allow controlling when each is updated separately).Technically this is a breaking change, but 6.2.0 was out for less than 24 hours, so extremely few people will be affected (they would have to have updated, written code against the new API, and worked around the lack of type export), and a breaking change to fix this would have much more disruptive effects on the ecosystem.
Fixes flutter/flutter#137278
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).