Skip to content

Add '--no-tree-shake-icons' option to BenchmarkServer #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 20, 2023
Merged

Add '--no-tree-shake-icons' option to BenchmarkServer #5186

merged 7 commits into from
Oct 20, 2023

Conversation

kenzieschmoll
Copy link
Member

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

yjbanov
yjbanov approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll kenzieschmoll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 19, 2023

auto label is removed for flutter/packages/5186, due to - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kenzieschmoll kenzieschmoll merged commit 2807d05 into flutter:main Oct 20, 2023
@kenzieschmoll kenzieschmoll deleted the noTreeShakeIcons branch October 20, 2023 16:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2023
@engine-flutter-autoroll
2807d05 Add '--no-tree-shake-icons' option to BenchmarkServer (flut…
fd8cdcd 
…ter/packages#5186)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 23, 2023
@engine-flutter-autoroll
Roll Packages from be915be to 4bf5114 (12 revisions) (#137062)
6dc5d2f 
flutter/packages@be915be...4bf5114

2023-10-23 PROGrand@users.noreply.github.com [camera] CameraPlatform.createCameraWithSettings (flutter/packages#3615)
2023-10-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/packages#5201)
2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter from 6f4850d to 823e083 (3 revisions) (flutter/packages#5198)
2023-10-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (flutter/packages#5167)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter from 0883cb2 to 6f4850d (24 revisions) (flutter/packages#5196)
2023-10-21 50643541+Mairramer@users.noreply.github.com [ios_platform_images]  migrate objC to swift (flutter/packages#4847)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#5149)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#5150)
2023-10-20 tarrinneal@gmail.com [quick_actions] convert to pigeon (flutter/packages#5159)
2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Add build-only Windows Arm64 tests (flutter/packages#5142)
2023-10-20 43759233+kenzieschmoll@users.noreply.github.com Add '--no-tree-shake-icons' option to `BenchmarkServer` (flutter/packages#5186)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter/packages#5192)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Oct 24, 2023
Merge branch 'main' into webview_patchedv5
813131e 
* main: (139 commits)
  Change firebase device tests from Android api 30 to 33 (flutter#5185)
  [url_launcher] Add an `inAppBrowserView` mode (flutter#5205)
  [ci] Remove device_type property from Windows Arm64 properties (flutter#5193)
  [url_launcher_web] Disallows launching "javascript:" URLs. (flutter#5180)
  [local_auth]: Bump androidx.fragment:fragment from 1.6.0 to 1.6.1 in /packages/local_auth/local_auth_android/android (flutter#4600)
  Roll Flutter from 823e083 to 5e8b5f4 (13 revisions) (flutter#5208)
  [tool] Add optional swift-format support (flutter#5204)
  [camera] CameraPlatform.createCameraWithSettings (flutter#3615)
  Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter#5201)
  Roll Flutter from 6f4850d to 823e083 (3 revisions) (flutter#5198)
  Bump actions/checkout from 4.1.0 to 4.1.1 (flutter#5167)
  Roll Flutter from 0883cb2 to 6f4850d (24 revisions) (flutter#5196)
  [ios_platform_images]  migrate objC to swift (flutter#4847)
  [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter#5149)
  [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5150)
  [quick_actions] convert to pigeon (flutter#5159)
  [ci] Add build-only Windows Arm64 tests (flutter#5142)
  Add '--no-tree-shake-icons' option to `BenchmarkServer` (flutter#5186)
  Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter#5192)
  [ci] Finalize migration to x64 specific Windows platform (flutter#5174)
  ...
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
p: web_benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenzieschmoll @yjbanov