[ci] Add x64 specific Windows platform #5133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
force-pushed
the
windows_x64_ci
branch
from
6326411 to
884d1ba
Compare
loic-sharma
commented
Oct 12, 2023
| ] | ||
| device_type: none | ||
| os: Windows | ||
| cpu: x86 |
There was a problem hiding this comment.
This line was added from the existing windows platform properties.
loic-sharma
changed the title
This was referenced Oct 13, 2023
stuartmorgan-g
approved these changes
Oct 13, 2023
|
@stuartmorgan Supporting VS2022 is tracked by flutter/flutter#96138. FWIW, VS2019 will receive security updates until April 2029. |
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 16, 2023
flutter/packages@fd84e65...872d6d2 2023-10-16 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.2 to 2.22.3 (flutter/packages#5151) 2023-10-15 engine-flutter-autoroll@skia.org Roll Flutter from 3865e49 to b00216b (34 revisions) (flutter/packages#5147) 2023-10-13 737941+loic-sharma@users.noreply.github.com [ci] Add x64 specific Windows platform (flutter/packages#5133) 2023-10-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.1 to 2.22.2 (flutter/packages#5138) 2023-10-13 engine-flutter-autoroll@skia.org Roll Flutter from 83134ac to 3865e49 (80 revisions) (flutter/packages#5140) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
#5133 began to migrate the Windows CI tests to use a new x64 specific Windows platform. This completes the migration by removing the old Windows tests and removing `bringup` from the new x64 specific tests. To see the resulting changes from both steps of the migration, refer to: 0bddb16...loic-sharma:flutter-packages:windows_x64_ci_finalize_2#diff-9e73abde9fff445f31e5928e80d2d3f88847e02fd8f76d46f66f147fdc82786d Prepares for flutter/flutter#129813 Previous stacked pull request: #5133 Next stacked pull request: #5142
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
Add build-only Windows Arm64 CI tests, mirroring the way we handle multi-arch for macOS. Completes: flutter/flutter#129813 Previous stacked pull requests: * #5133 * #5174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins to migrate the Windows CI tests to use a new x64 specific Windows platform. For now these duplicate the existing tests in
bringupmode.A subsequent pull request (#5141) will complete the migration by removing the old Windows tests and removing the
bringupfrom the new x64 specific tests. Here are the resulting changes from both steps of the migration: main...loic-sharma:flutter-packages:windows_x64_ci_finalizeIn the future, a new platform will be added for Windows Arm64 tests.
Prepares for flutter/flutter#129813
Subsequent pull requests:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.