-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ios_platform_images] Add extension tests #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 3 commits into
flutter:main
from
stuartmorgan-g:ios-platform-images-extension-unit-tests
Sep 14, 2023
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
packages/ios_platform_images/example/ios/RunnerTests/UIImage+ios_platform_imagesTests.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright 2013 The Flutter Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| @import ios_platform_images; | ||
| @import XCTest; | ||
|
|
||
| // The tests test the UIImage extension which is a public API intended for use from native code | ||
| // outside of the plugin (see package README). Any change that requires changing existing tests | ||
| // in this file (unless it's just to reflect changes to the test assets) is a BREAKING CHANGE for | ||
| // the package. | ||
| @interface UIImageExtensionTests : XCTestCase | ||
| @end | ||
|
|
||
| @implementation UIImageExtensionTests | ||
|
|
||
| - (void)testMultiResolutionImageUsesBest { | ||
| UIImage *image = [UIImage flutterImageWithName:@"assets/multisize.png"]; | ||
| XCTAssertNotNil(image); | ||
| const double height1x = 125; // The height of assets/multisize.png. | ||
| const double height2x = 250; // The height of assets/2.0x/multisize.png. | ||
| // Loading assets should get the best available asset for the screen scale when resolution-aware | ||
| // assets are available (and the example app has 1x and 2x for this asset). See | ||
| // https://docs.flutter.dev/ui/assets/assets-and-images#resolution-aware | ||
| if (UIScreen.mainScreen.scale > 1.0) { | ||
| XCTAssertEqualWithAccuracy(image.size.height, height2x, 0.00001); | ||
| } else { | ||
| XCTAssertEqualWithAccuracy(image.size.height, height1x, 0.00001); | ||
| } | ||
| } | ||
|
|
||
| - (void)testSingleResolutionFindsImage { | ||
| // When there is no resolution-aware asset, the main asset should be used. | ||
| UIImage *image = [UIImage flutterImageWithName:@"assets/monosize.png"]; | ||
| XCTAssertNotNil(image); | ||
| } | ||
|
|
||
| - (void)testMissingImageReturnsNil { | ||
| UIImage *image = [UIImage flutterImageWithName:@"assets/no_such_image.png"]; | ||
| XCTAssertNil(image); | ||
| } | ||
|
|
||
| @end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,4 +25,6 @@ dev_dependencies: | |
| sdk: flutter | ||
|
|
||
| flutter: | ||
| assets: | ||
| - assets/ | ||
| uses-material-design: true | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow im surprised that this is a public API.