Skip to content

[ci] Enable ios_platform_images tests #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

#4899 added integration tests, but I forgot that they were being excluded in CI. This enables them.

Fixes flutter/flutter#82208

flutter#4899 added integration tests,
but I forgot that they were being excluded in CI. This enables them.

Fixes flutter/flutter#82208
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this might be important

@stuartmorgan-g
Copy link
Contributor Author

Note to self: I actually checked that the test is running in CI this time.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit 0a86513 into flutter:main Sep 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 15, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 15, 2023
flutter/packages@275b76c...bc8c2f2

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 stuartmorgan@google.com [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929)
2023-09-14 stuartmorgan@google.com [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928)
2023-09-14 43054281+camsim99@users.noreply.github.com Manual Roll of Flutter from 4e7a07a to 61b890b   (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
11 tasks
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
flutter/packages@275b76c...bc8c2f2

2023-09-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.6 to 2.21.7 (flutter/packages#4930)
2023-09-14 stuartmorgan@google.com [ios_platform_images] Add extension tests (flutter/packages#4925)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2524052 to 367f9ea (3 revisions) (flutter/packages#4929)
2023-09-14 stuartmorgan@google.com [ci] Enable ios_platform_images tests (flutter/packages#4920)
2023-09-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/packages#4922)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter from 61b890b to 58ba6c2 (16 revisions) (flutter/packages#4928)
2023-09-14 43054281+camsim99@users.noreply.github.com Manual Roll of Flutter from 4e7a07a to 61b890b   (flutter/packages#4919)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios_platform_images] missing integration tests
2 participants