[ci] Wait for LUCI test checkin in release
#4911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the possibilty of the `release` action's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.
|
@godofredoc Ping; can you verify that this is what you had in mind for this change? |
|
@godofredoc Ping on this trivial review. |
godofredoc
approved these changes
Sep 29, 2023
Taking a look.
Done, sorry for the delay! |
stuartmorgan-g
added
the
autosubmit
|
auto label is removed for flutter/packages/4911, due to - The status or check suite Linux_android android_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2023
flutter/packages@d0e9a0e...e2ac440 2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044) 2023-10-01 maurits@vnbskm.nl [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043) 2023-09-30 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Add a method for getting the user agent (flutter/packages#4472) 2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037) 2023-09-29 stuartmorgan@google.com [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911) 2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927) 2023-09-29 stuartmorgan@google.com [ci] Disable maps tests in Android emulator (flutter/packages#5003) 2023-09-29 33461698+BradenBagby@users.noreply.github.com [camera] Dispose resources correctly on setDescription (flutter/packages#4003) 2023-09-29 maurits@vnbskm.nl [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702) 2023-09-29 stuartmorgan@google.com [camera] Remove `@throw` from iOS implementation (flutter/packages#5034) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@d0e9a0e...e2ac440 2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044) 2023-10-01 maurits@vnbskm.nl [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043) 2023-09-30 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Add a method for getting the user agent (flutter/packages#4472) 2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037) 2023-09-29 stuartmorgan@google.com [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911) 2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927) 2023-09-29 stuartmorgan@google.com [ci] Disable maps tests in Android emulator (flutter/packages#5003) 2023-09-29 33461698+BradenBagby@users.noreply.github.com [camera] Dispose resources correctly on setDescription (flutter/packages#4003) 2023-09-29 maurits@vnbskm.nl [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702) 2023-09-29 stuartmorgan@google.com [camera] Remove `@throw` from iOS implementation (flutter/packages#5034) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the possibilty of the
releaseaction's wait-for-all-tests step completing before any LUCI tests have even checked in, by first waiting for a known LUCI test to show up.