Remove deprecated ImageProvider methods
#4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
force-pushed
the
remove-ImageProvider-load
branch
from
6a68077
to
a0500a0
Compare
8 tasks
LongCatIsLooong
force-pushed
the
remove-ImageProvider-load
branch
from
addee8c
to
535f627
Compare
LongCatIsLooong
force-pushed
the
remove-ImageProvider-load
branch
from
535f627
to
0bdaf23
Compare
|
|
|
@stuartmorgan is a version bump needed for this change? |
stuartmorgan
requested changes
Aug 18, 2023
There was a problem hiding this comment.
Yes, this changes production code so it needs a version bump. See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version for the list of cases that don't.
| @@ -140,12 +140,12 @@ void assertThatImageLoadingFails( | |||
| NetworkImageWithRetry subject, | |||
| List<FlutterErrorDetails> errorLog, | |||
| ) { | |||
| final ImageStreamCompleter completer = subject.load( | |||
| final ImageStreamCompleter completer = subject.loadBuffer( | |||
| subject, | |||
| // TODO(cyanglaz): migrate to use the new APIs | |||
| // https://github.com/flutter/flutter/issues/105336 | |||
| // ignore: deprecated_member_use | |||
There was a problem hiding this comment.
This replacement is also deprecated?
There was a problem hiding this comment.
Yeah the up-to-date APIs are only available in >v3.7.0 unfortunately. Included in the new issue.
| @@ -160,12 +160,12 @@ void assertThatImageLoadingFails( | |||
| void assertThatImageLoadingSucceeds( | |||
| NetworkImageWithRetry subject, | |||
| ) { | |||
| final ImageStreamCompleter completer = subject.load( | |||
| final ImageStreamCompleter completer = subject.loadBuffer( | |||
| subject, | |||
| // TODO(cyanglaz): migrate to use the new APIs | |||
| // https://github.com/flutter/flutter/issues/105336 | |||
| // ignore: deprecated_member_use | |||
| ImageStreamCompleter loadBuffer( | ||
| NetworkImageWithRetry key, | ||
| // TODO(cyanglaz): migrate to use the new APIs | ||
| // https://github.com/flutter/flutter/issues/105336 |
There was a problem hiding this comment.
This issue is about APIs deprecated a year ago, so shouldn't still be applicable to new code. If there's a new migration needed, there should be a new issue describing it clearly (the old API, the new API, and the version it's in).
There was a problem hiding this comment.
Created flutter/flutter#132856
stuartmorgan
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
LGTM, thanks!
Alternately, it's also totally fine to just make the minimum version 3.10 and fully eliminate the deprecated APIs (per https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#supported-flutter-versions)
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2023
flutter/packages@c730a90...3060b1a 2023-08-23 ian@hixie.ch [rfw] Support web (as JS) (flutter/packages#4650) 2023-08-22 84124091+opxdelwin@users.noreply.github.com [webview_flutter] Update sample code. (flutter/packages#4727) 2023-08-22 ctrysbita@outlook.com [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661) 2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `ImageProvider` methods (flutter/packages#4725) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong
added a commit
to flutter/flutter
that referenced
this pull request
Aug 24, 2023
…nstantiateImageCodec` (#132679) ~The failing plugin tests should pass once flutter/packages#4725 lands and rolls into flutter/flutter~ google tests are migrated. Part of #133171 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to keep
loadBuffersinceloadImageisn't available on 3.7.Fixes flutter/flutter#105336
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.